Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added announcer for selected files in files app bar #4833

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Added announcer for selected files in files app bar #4833

merged 1 commit into from
Mar 25, 2021

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 22, 2021 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@AlexAndBear
Copy link
Contributor Author

@marcus-herrmann Feedback is welcome :)

marcus-herrmann
marcus-herrmann approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@marcus-herrmann marcus-herrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see this is the first permanent polite live region, right? I only discovered an assertive one in FilesUploadProgress so far, but haven't checked everything/every state

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Mar 22, 2021 •
edited
Loading

@marcus-herrmann we also have the permanent polite live region for the route changes, are more than one bad design?

@marcus-herrmann
Copy link
Contributor

are more than one bad design?

Can't really tell at the moment without testing, but I read none of the like.

@owncloud owncloud deleted a comment from update-docs bot Mar 22, 2021
@AlexAndBear AlexAndBear force-pushed the a11y-files-app-barenhancement branch from 74a4de4 to 6133299 Compare March 22, 2021 10:34
@AlexAndBear AlexAndBear marked this pull request as ready for review March 22, 2021 10:48
@AlexAndBear AlexAndBear merged commit 8dbc29c into master Mar 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the a11y-files-app-barenhancement branch March 25, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@marcus-herrmann marcus-herrmann marcus-herrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit #1 – General Overview when logged in – Checkbox in Files Table opens dialog in DOM above Files Table
3 participants
@AlexAndBear @marcus-herrmann @kulmann