Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ODS to 4.1.2 #4862

Merged
merged 43 commits into from
Mar 31, 2021
Merged

Update ODS to 4.1.2 #4862

merged 43 commits into from
Mar 31, 2021

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Mar 25, 2021 •
edited by kulmann
Loading

Description

Brings a new major version of the ownCloud design system, featuring a lot of accessibility improvements, a new color palette, the option to use theming as well as changes in the way variations are handled in icons, buttons and more.

Motivation and Context

Needed for accessibility certifications and theming features.

Types of changes

  • Breaking change

Checklist:

Open tasks:

  • Update all icons that use url
  • Update all icons that use variation="raw|file-type|system"
  • Update all buttons that use variation="raw" (update to appearance="raw")
  • Labels for all textinputs are required (annotation by @JammingBen : I believe they already are, but let's at least verify that 👍 Maybe we even have to remove some labels as they appear twice now). This goes for goes for oc-text-input, oc-textarea, oc-autocomplete and oc-datepicker.
  • Placeholders need to be removed as they was there to describe the input, use description-message instead (goes for oc-text-input, oc-textarea. Not in oc-datepicker until we've updated that and not in oc-autocomplete for now, though)
  • Add accessible-label to all icons and images which are not decoration only (exception: icons that sit in a icon-only-button which is described via aria-label already)
  • Rename the ariaLabel property of each oc-autocomplete to label
  • Visual: Check appearance of inputs which now should have a label (margins have to be adjusted possibly)
  • upload a file again for creating a new version. Button in modal has disabled style but works properly.
  • modals for creating a new file / folder and for renaming a new file/folder: label + prefilled name + description is too much. I'd vote for just removing the description message.
  • copy/move location picker: breadcrumbs look weird compared to title. Maybe have a proper H1 and then the breadcrumbs in a new line? Or bigger breadcrumbs again, like before?
  • "Paste here" or "Move here" button is the primary action -> should have filled appearance
  • "There are no resources in this folder." looks weird with the gray text. passive variation for text possible? or also not good looking? (uk-text-muted referred to uikit's muted. Fixed in ODS via overwriting it so we can release another minor version & link it later)

Delayed tasks

  • Replacing placeholders in <oc-modal> forms with description-messages (needs another ODS update)
  • Replacing placeholders in <oc-autocomplete> forms with description-messages (needs another ODS update)

@update-docs
Copy link

update-docs bot commented Mar 25, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter force-pushed the 25032021_bump_ODS_to_4_0_0 branch from c4d652e to 19faeae Compare March 25, 2021 15:48
@pascalwengerter pascalwengerter changed the title [WIP] [skip-ci] Update ODS to 4.0.0 [WIP] Update ODS to 4.0.0 Mar 25, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsEdgeCases failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155631-412.png
20210325-155722-594.png
20210325-155804-150.png
20210325-155840-601.png
20210325-155931-581.png
20210325-160007-335.png
20210325-160042-250.png
20210325-160121-096.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155656-852.png
20210325-155732-528.png
20210325-155812-796.png
20210325-155847-559.png
20210325-155923-638.png
20210325-155959-489.png
20210325-160035-167.png
20210325-160110-531.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsRootEdgeCases failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155718-616.png
20210325-155756-214.png
20210325-155837-931.png
20210325-155924-388.png
20210325-155958-881.png
20210325-160033-364.png
20210325-160109-101.png
20210325-160142-952.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingFilePermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155613-635.png
20210325-155657-862.png
20210325-155736-972.png
20210325-155823-610.png
20210325-155901-724.png
20210325-155942-296.png
20210325-160020-448.png
20210325-160100-093.png
20210325-160141-424.png
20210325-160230-328.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155746-699.png
20210325-155827-777.png
20210325-155911-016.png
20210325-155947-953.png
20210325-160025-707.png
20210325-160102-339.png
20210325-160142-520.png
20210325-160221-128.png
20210325-160321-206.png
20210325-160358-950.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155559-417.png
20210325-155802-408.png
20210325-155850-502.png
20210325-155938-878.png
20210325-155939-102.png
20210325-160016-254.png
20210325-160016-525.png
20210325-160211-810.png
20210325-160258-111.png
20210325-160343-370.png
20210325-160343-584.png
20210325-160435-551.png
20210325-160435-732.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingFolderPermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155743-097.png
20210325-155820-825.png
20210325-155908-756.png
20210325-155945-724.png
20210325-160021-787.png
20210325-160057-301.png
20210325-160132-410.png
20210325-160208-839.png
20210325-160246-633.png
20210325-160325-722.png
20210325-160400-863.png
20210325-160435-393.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingFolderPermissionMultipleUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155708-116.png
20210325-155750-627.png
20210325-155847-038.png
20210325-155931-265.png
20210325-160009-385.png
20210325-160048-424.png
20210325-160126-448.png
20210325-160204-517.png
20210325-160243-011.png
20210325-160320-470.png
20210325-160403-244.png
20210325-160441-664.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155702-008.png
20210325-155740-026.png
20210325-155817-285.png
20210325-155856-410.png
20210325-155933-473.png
20210325-160008-987.png
20210325-160044-589.png
20210325-160122-434.png
20210325-160158-519.png
20210325-160233-648.png
20210325-160310-109.png
20210325-160342-429.png
20210325-160417-111.png
20210325-160450-677.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsersRootSharingIndicator failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155643-134.png
20210325-155717-305.png
20210325-155757-703.png
20210325-155838-782.png
20210325-155919-313.png
20210325-155958-344.png
20210325-160029-691.png
20210325-160103-426.png
20210325-160136-597.png
20210325-160210-356.png
20210325-160244-122.png
20210325-160316-450.png
20210325-160354-130.png
20210325-160425-794.png
20210325-160504-331.png
20210325-160550-212.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsRootSharingIndicator failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155644-298.png
20210325-155719-487.png
20210325-155759-536.png
20210325-155838-321.png
20210325-155913-338.png
20210325-155952-382.png
20210325-160026-641.png
20210325-160100-276.png
20210325-160138-753.png
20210325-160217-688.png
20210325-160252-607.png
20210325-160326-725.png
20210325-160402-824.png
20210325-160434-934.png
20210325-160510-834.png
20210325-160606-228.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsersSharingIndicator failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155720-229.png
20210325-155809-393.png
20210325-155849-853.png
20210325-155924-041.png
20210325-160003-413.png
20210325-160046-161.png
20210325-160129-966.png
20210325-160209-964.png
20210325-160244-593.png
20210325-160319-808.png
20210325-160353-627.png
20210325-160427-096.png
20210325-160502-825.png
20210325-160536-009.png
20210325-160608-629.png
20210325-160641-234.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsersBlacklisted failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-160024-038.png
20210325-160109-180.png
20210325-160211-963.png
20210325-160255-659.png
20210325-160340-006.png
20210325-160422-710.png
20210325-160501-823.png
20210325-160539-403.png
20210325-160620-879.png
20210325-160703-807.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinRestore failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155743-000.png
20210325-155819-917.png
20210325-155901-896.png
20210325-155938-504.png
20210325-160017-159.png
20210325-160055-310.png
20210325-160133-094.png
20210325-160211-588.png
20210325-160251-121.png
20210325-160329-728.png
20210325-160405-379.png
20210325-160443-152.png
20210325-160521-037.png
20210325-160559-266.png
20210325-160637-100.png
20210325-160714-633.png
20210325-160756-485.png
20210325-160838-343.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155641-295.png
20210325-155715-547.png
20210325-155752-389.png
20210325-155830-605.png
20210325-155904-854.png
20210325-155939-054.png
20210325-160014-189.png
20210325-160046-559.png
20210325-160121-010.png
20210325-160200-400.png
20210325-160233-914.png
20210325-160311-978.png
20210325-160349-644.png
20210325-160421-776.png
20210325-160454-738.png
20210325-160532-828.png
20210325-160606-528.png
20210325-160639-840.png
20210325-160713-735.png
20210325-160746-297.png
20210325-160819-293.png
20210325-160853-389.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsersRootBlacklisted failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-160151-767.png
20210325-160259-084.png
20210325-160402-038.png
20210325-160501-938.png
20210325-160614-653.png
20210325-160712-230.png
20210325-160758-753.png
20210325-160849-281.png
20210325-160939-914.png
20210325-161026-995.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests RestrictSharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-160012-439.png
20210325-160047-540.png
20210325-160125-307.png
20210325-160202-900.png
20210325-160244-128.png
20210325-160326-836.png
20210325-160426-117.png
20210325-160503-741.png
20210325-160540-952.png
20210325-160616-507.png
20210325-160653-203.png
20210325-160728-970.png
20210325-160803-367.png
20210325-160838-468.png
20210325-160913-723.png
20210325-160951-947.png
20210325-161027-819.png
20210325-161104-230.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingFolderAdvancedPermissionMU failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155648-339.png
20210325-155730-503.png
20210325-155813-937.png
20210325-155854-182.png
20210325-155933-570.png
20210325-160011-970.png
20210325-160053-157.png
20210325-160135-027.png
20210325-160215-545.png
20210325-160300-123.png
20210325-160346-265.png
20210325-160424-884.png
20210325-160501-178.png
20210325-160542-462.png
20210325-160620-318.png
20210325-160657-145.png
20210325-160736-163.png
20210325-160813-287.png
20210325-160850-434.png
20210325-160926-791.png
20210325-161003-505.png
20210325-161041-697.png
20210325-161119-256.png
20210325-161155-839.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingFilePermissionMultipleUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-160150-923.png
20210325-160247-244.png
20210325-160359-414.png
20210325-160502-737.png
20210325-160606-639.png
20210325-160658-933.png
20210325-160751-680.png
20210325-160850-335.png
20210325-160935-025.png
20210325-161020-283.png
20210325-161106-477.png
20210325-161159-319.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155652-814.png
20210325-155728-680.png
20210325-155807-357.png
20210325-155843-757.png
20210325-155918-377.png
20210325-155952-721.png
20210325-160027-522.png
20210325-160103-893.png
20210325-160208-632.png
20210325-160244-148.png
20210325-160331-981.png
20210325-160418-557.png
20210325-160457-706.png
20210325-160530-595.png
20210325-160607-064.png
20210325-160646-639.png
20210325-160721-719.png
20210325-160755-766.png
20210325-160837-806.png
20210325-160918-007.png
20210325-160958-835.png
20210325-161039-851.png
20210325-161121-043.png
20210325-161203-804.png
20210325-161238-303.png
20210325-161313-290.png
20210325-161347-739.png
20210325-161422-826.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingFolderAdvPermissionsGrp failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155929-147.png
20210325-160005-604.png
20210325-160042-919.png
20210325-160121-055.png
20210325-160157-285.png
20210325-160234-280.png
20210325-160310-973.png
20210325-160346-459.png
20210325-160424-001.png
20210325-160459-971.png
20210325-160536-612.png
20210325-160614-462.png
20210325-160653-453.png
20210325-160729-630.png
20210325-160805-004.png
20210325-160842-744.png
20210325-160919-065.png
20210325-160955-942.png
20210325-161032-566.png
20210325-161109-507.png
20210325-161145-144.png
20210325-161223-789.png
20210325-161259-780.png
20210325-161335-358.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Favorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-160018-816.png
20210325-160056-892.png
20210325-160132-608.png
20210325-160207-710.png
20210325-160243-925.png
20210325-160320-577.png
20210325-160413-827.png
20210325-160450-872.png
20210325-160558-209.png
20210325-160632-181.png
20210325-160709-393.png
20210325-160745-701.png
20210325-160820-426.png
20210325-160854-765.png
20210325-160929-076.png
20210325-161004-719.png
20210325-161038-558.png
20210325-161113-570.png
20210325-161149-249.png
20210325-161225-438.png
20210325-161259-810.png
20210325-161332-928.png
20210325-161405-581.png
20210325-161438-850.png
20210325-161513-988.png
20210325-161549-775.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-160013-330.png
20210325-160055-772.png
20210325-160131-118.png
20210325-160206-708.png
20210325-160241-607.png
20210325-160317-074.png
20210325-160352-308.png
20210325-160427-568.png
20210325-160504-018.png
20210325-160540-014.png
20210325-160613-464.png
20210325-160647-711.png
20210325-160721-003.png
20210325-160754-699.png
20210325-160828-193.png
20210325-160902-881.png
20210325-160937-786.png
20210325-161011-437.png
20210325-161044-986.png
20210325-161119-809.png
20210325-161154-236.png
20210325-161229-491.png
20210325-161304-060.png
20210325-161337-492.png
20210325-161410-662.png
20210325-161444-160.png
20210325-161517-668.png
20210325-161552-103.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsersExpireToRoot failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155708-430.png
20210325-155742-142.png
20210325-155823-706.png
20210325-155914-308.png
20210325-155946-316.png
20210325-160020-246.png
20210325-160053-892.png
20210325-160128-468.png
20210325-160201-762.png
20210325-160234-887.png
20210325-160309-346.png
20210325-160342-738.png
20210325-160420-100.png
20210325-160454-343.png
20210325-160529-734.png
20210325-160602-202.png
20210325-160635-465.png
20210325-160710-670.png
20210325-160743-348.png
20210325-160815-894.png
20210325-160849-015.png
20210325-160922-859.png
20210325-160956-478.png
20210325-161029-768.png
20210325-161103-745.png
20210325-161139-347.png
20210325-161213-027.png
20210325-161246-778.png
20210325-161320-258.png
20210325-161352-776.png
20210325-161423-903.png
20210325-161455-713.png
20210325-161527-396.png
20210325-161558-560.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalUsersExpire failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13854/

20210325-155645-771.png
20210325-155720-312.png
20210325-155801-616.png
20210325-155837-671.png
20210325-155911-993.png
20210325-155946-451.png
20210325-160022-892.png
20210325-160058-655.png
20210325-160140-069.png
20210325-160216-951.png
20210325-160253-591.png
20210325-160332-006.png
20210325-160407-283.png
20210325-160444-748.png
20210325-160518-917.png
20210325-160553-049.png
20210325-160632-053.png
20210325-160706-828.png
20210325-160742-109.png
20210325-160816-328.png
20210325-160851-962.png
20210325-160927-230.png
20210325-161002-475.png
20210325-161037-758.png
20210325-161113-491.png
20210325-161150-202.png
20210325-161225-636.png
20210325-161301-787.png
20210325-161336-227.png
20210325-161409-411.png
20210325-161444-089.png
20210325-161518-387.png
20210325-161553-858.png
20210325-161628-833.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14017/

20210330-085700-064.png
20210330-085734-747.png
20210330-090341-440.png
20210330-090415-190.png
20210330-090449-795.png
20210330-090524-105.png
20210330-090723-114.png
20210330-090759-723.png
20210330-090857-757.png
20210330-090934-235.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14042/

20210330-124826-582.png
20210330-124900-321.png
20210330-125424-003.png
20210330-125455-585.png
20210330-125527-291.png
20210330-125557-988.png
20210330-125737-467.png
20210330-125809-943.png
20210330-125920-028.png
20210330-125953-805.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14046/

20210330-134342-983.png
20210330-134406-498.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14051/

20210330-142609-442.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14051/

20210330-144025-219.png

@kulmann
Copy link
Contributor

kulmann commented Mar 30, 2021 •
edited
Loading

2 random failures in CI left. Restarted CI, let's see if it turns green. 🤞

@LukasHirt
Copy link
Collaborator

Is this on purpose that actions are now having an underline on hover? Feels wrong to me TBH... it's like pretending they're links 🤷

image

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14087/

20210331-091850-541.png
20210331-091906-626.png

@kulmann
Copy link
Contributor

kulmann commented Mar 31, 2021

Is this on purpose that actions are now having an underline on hover? Feels wrong to me TBH... it's like pretending they're links 🤷

image

Same goes for files in the file list. The underline feels wrong.

@pascalwengerter
Copy link
Contributor Author

Is this on purpose that actions are now having an underline on hover? Feels wrong to me TBH... it's like pretending they're links 🤷
image

Same goes for files in the file list. The underline feels wrong.

Fixed in ODS 1185

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14101/

20210331-122917-789.png
20210331-122952-081.png

@kulmann kulmann changed the title [WIP] Update ODS to 4.1.0 Update ODS to 4.1.2 Mar 31, 2021
@kulmann
Copy link
Contributor

kulmann commented Mar 31, 2021

Merging now without a successful CI run. There are some different random failures. Restarting until we have a green run seems to be close to impossible.

@kulmann kulmann merged commit d51b359 into master Mar 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the 25032021_bump_ODS_to_4_0_0 branch March 31, 2021 12:48
@pascalwengerter pascalwengerter mentioned this pull request Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@pascalwengerter pascalwengerter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pascalwengerter @ownclouders @kulmann @LukasHirt @JammingBen @individual-it