New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create shared by link page #4881

Merged

LukasHirt merged 9 commits into master from split-shared-with-pages

Mar 31, 2021

Collaborator

LukasHirt commented Mar 29, 2021 •

edited

Loading

We've added a new page called "Shared via link". This page displays a files list containing only resources shared via public links.

LukasHirt self-assigned this

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

LukasHirt force-pushed the split-shared-with-pages branch from e5c436d to b918a78 Compare

March 30, 2021 08:05

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Contributor

wkloucek commented Mar 30, 2021

@LukasHirt please switch to owncloudci/golang:1.16

Collaborator Author

LukasHirt commented Mar 30, 2021

please switch to owncloudci/golang:1.16

I'll do that, thanks! @wkloucek

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

LukasHirt force-pushed the split-shared-with-pages branch 2 times, most recently from 15bca11 to 4318259 Compare

March 30, 2021 10:42

Collaborator Author

LukasHirt commented Mar 30, 2021 •

edited

Loading

Reverted back to webhippie as the owncloudci golang images are breaking the CI currently. Need to be taken care of in own PR #4890

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

individual-it mentioned this pull request

enabled screenshots and failing VRT tests seem not to work together #4869

Closed

Collaborator Author

LukasHirt commented Mar 30, 2021 •

edited

Loading

Tests randomly failing in the CI but not locally (will be updating this comment in case of new ones):

webUISharingExternalToRoot/federationSharing.feature:250
webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:92
webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:92

This comment has been minimized.

Sign in to view

LukasHirt force-pushed the split-shared-with-pages branch from 753bfeb to 0b893aa Compare

March 30, 2021 13:52

LukasHirt requested review from kulmann and pascalwengerter

March 30, 2021 14:00

LukasHirt marked this pull request as ready for review

March 30, 2021 14:01

This comment has been minimized.

Sign in to view

kulmann suggested changes

View reviewed changes

packages/web-app-files/src/views/SharedViaLink.vue Outdated Show resolved Hide resolved

packages/web-app-files/src/views/SharedViaLink.vue Outdated Show resolved Hide resolved

Contributor

ownclouders commented Mar 30, 2021

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14047/

Diff Image:

Actual Image:

Comparing Against:

Contributor

ownclouders commented Mar 30, 2021

💥 Acceptance tests SharingInternalGroupsRootSharingIndicator failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14052/

Collaborator Author

LukasHirt commented Mar 30, 2021

@individual-it Could anybody from your team pls update the screenshot in oCIS for webUIFiles/fileList.feature:40? We currently have issues running acceptance tests for oCIS on mac so I cannot updated them there. I tried to copy the screenshot from oC10 but oCIS hasn't got Favorites item 🙈

kulmann approved these changes

View reviewed changes

Contributor

kulmann left a comment

Looks good to me 👍 baseline image of the sidebar for ocis needs to be solved.

Contributor

ownclouders commented Mar 30, 2021

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14049/

Diff Image:

Actual Image:

Comparing Against:

Contributor

ownclouders commented Mar 30, 2021

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14052/

Diff Image:

Actual Image:

Comparing Against:

Member

individual-it commented Mar 31, 2021

we are tracking random failures currently here #4878
I've added webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:92

webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:92 was already on the list

and I could not find any drone run where webUISharingExternalToRoot/federationSharing.feature:250 failed

Contributor

ownclouders commented Mar 31, 2021

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14071/

Member

individual-it commented Mar 31, 2021

deletion has still a problem with locked files on oC10. Tests will be skipped in #4897

see also
#4582
#4784

LukasHirt and others added 9 commits

March 31, 2021 14:41


          Create shared by link page

4347c60


          Rename to Shared via link

fc893d1


          Add public links page tests

03c98ee


          Remove share status

7406ffc


          Tests: update sidebar screenshot

f3a7274


          Add changelog

4d76666


          feat: fix file name, remove size from shared with others and fix ids …

5109b16

…in shared via link


          update baseline image of sidebar in ocis

74db318


          wait for sharing indicators to be visible before checking them

42f50a5

individual-it force-pushed the split-shared-with-pages branch from e943f40 to 42f50a5 Compare

March 31, 2021 08:56

Contributor

ownclouders commented Mar 31, 2021

💥 Acceptance tests SharingInternalGroupsRootSharingIndicator failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14089/

LukasHirt merged commit fbbeb7c into master

LukasHirt deleted the split-shared-with-pages branch

March 31, 2021 10:00

LukasHirt mentioned this pull request

[web] FEATURE: I don't see a Public links pane #4650

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet