-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests and optimize #4907
Tests and optimize #4907
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
💥 Acceptance tests SharingInternalGroupsRootEdgeCases failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalGroupsEdgeCases failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingFilePermissionsGroups failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalUsersBlacklisted failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingFolderPermissionsGroups failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalUsersRootBlacklisted failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingFilePermissionMultipleUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingFolderPermissionMultipleUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalGroupsRootSharingIndicator failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalUsersRootSharingIndicator failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests TrashbinRestore failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalUsersSharingIndicator failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests Favorites failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests RestrictSharing failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingFolderAdvPermissionsGrp failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingFolderAdvancedPermissionMU failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalUsersExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests webUICreate failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalUsersExpireToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalGroupsRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests Upload failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests ResharingToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingPermissionToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests Resharing failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingInternalUsersRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
💥 Acceptance tests Files failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14189/
|
3422b29
to
2ff085e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After bringing back stubs it's good to go 🚀
extract theme loading into own helper method add test to verify theme loading is working as expected fix theme loading, before it has overwritten the whole theme object, now we respect the values and keys that are set-able. add init step for fetchMock to use mocks in testing by default clean up config test to use global fetch to be able to reset the store in tests we started to use createStore from vuex-extensions which offers a reset method to get back the initial state fine-tune jest to ignore lodash-es which is problematic in some cases introduce web-pkg which provides globally used functionality add and write tests for keysDeep which is similar to lodash keys but deep rename web-runtime Top-Bar component to match style move TopBar tests to web-runtime move web-runtime config to helpers folder move config spec from toplevel to package level bump core-js
e8c4734
to
183f838
Compare
@@ -0,0 +1,6 @@ | |||
Change: Add web-pkg package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an enhancement (no breaking change => we call non-breaking changes enhancement
).
Description
in #2362 we we started to work intensive on theming. This needs some testing to be sure everything works as expected. In the same breath it was a good moment in time to refactor and align some testing workflows.
once #4822 is finalized we need to touch the theme loading and testing again because the pr introduces theme keys.
Related Issue
Motivation and Context
we need more unit tests
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: