Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] choose-tests-for-ocisSmokeTest: add tag ocisSmokeTest #5315

Merged
merged 4 commits into from
Jun 25, 2021
Merged

[full-ci] [tests-only] choose-tests-for-ocisSmokeTest: add tag ocisSmokeTest #5315

merged 4 commits into from
Jun 25, 2021

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jun 20, 2021 •
edited
Loading

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingInternalUsers2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingPermissions1 failed. The build is cancelled...

phil-davis
phil-davis reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please sort out whatever is needed to "sign the CLA"

tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature Outdated Show resolved Hide resolved
phil-davis
phil-davis reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor we try to leave 2 lines between each scenario. That allows us to have an empty line, and then a line that has filter-tags on it. When there are no filter-tags for a scenario, that 2nd line is empty.

That allows us to add/change filter-tags on scenarios without the line numbers changing. And that reduces "annoying" changes to line-number references in expected-failures files.

@phil-davis phil-davis self-requested a review June 21, 2021 07:18
@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingPublic failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingPermissions3 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCISBasic failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsers failed. The build is cancelled...

@ScharfViktor ScharfViktor force-pushed the choose-tests-for-ocisSmokeTest branch from ac05823 to 4426f85 Compare June 24, 2021 09:34
@owncloud owncloud deleted a comment from update-docs bot Jun 24, 2021
@phil-davis phil-davis changed the title choose-tests-for-ocisSmokeTest: add tag ocisSmokeTest [tests-only] choose-tests-for-ocisSmokeTest: add tag ocisSmokeTest Jun 24, 2021
@phil-davis phil-davis self-requested a review June 24, 2021 09:37
@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/16816/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16829/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/16829/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ScharfViktor ScharfViktor force-pushed the choose-tests-for-ocisSmokeTest branch from 5828851 to dcbc230 Compare June 24, 2021 10:57
phil-davis
phil-davis approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please squash the commits

And it still thinks that you need to "sign" the CLA.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16831/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/16831/63/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ScharfViktor ScharfViktor force-pushed the choose-tests-for-ocisSmokeTest branch from dcbc230 to 39f794a Compare June 24, 2021 11:35
@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16833/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/16833/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16835/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/16835/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16837/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/16837/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@phil-davis
Copy link
Contributor

@ScharfViktor you need to amend the first commit and make your real GitHub name and email address be the Author.

Maybe some git commands like this: https://www.codegrepper.com/code-examples/shell/how+to+remove+author+from+git+commit

@ownclouders
Copy link
Contributor

Results for oC10Basic https://drone.owncloud.com/owncloud/web/16847/6/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUILogin-adminBlocksUser-feature-20.png

webUILogin-adminBlocksUser-feature-20.png

webUIPreview-imageMediaViewer-feature-141.png

webUIPreview-imageMediaViewer-feature-141.png

webUIPreview-imageMediaViewer-feature-159.png

webUIPreview-imageMediaViewer-feature-159.png

webUIPreview-imageMediaViewer-feature-84.png

webUIPreview-imageMediaViewer-feature-84.png

webUIPreview-imageMediaViewer-feature-91.png

webUIPreview-imageMediaViewer-feature-91.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@phil-davis phil-davis changed the title [tests-only] choose-tests-for-ocisSmokeTest: add tag ocisSmokeTest [full-ci] [tests-only] choose-tests-for-ocisSmokeTest: add tag ocisSmokeTest Jun 25, 2021
@phil-davis phil-davis force-pushed the choose-tests-for-ocisSmokeTest branch from 8ad7fbd to 06df5f8 Compare June 25, 2021 08:07
@phil-davis
Copy link
Contributor

phil-davis commented Jun 25, 2021 •
edited
Loading

@ScharfViktor the problem was that the line numbers changed in some feature files, so the line numbers need to be adjusted in expected-failures files.

I pushed a commit for that. And I put full-ci in the PR title. That makes all the pipelines run to completion (no early fail). That will let us see all failures.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16850/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16857/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@phil-davis phil-davis mentioned this pull request Jun 25, 2021
Closed
@phil-davis
Copy link
Contributor

Now I understand the failures. Some scenarios have been added to the smoke tests, and pipelines like https://drone.owncloud.com/owncloud/web/16857/44/14 oC10iPhone2-chrome run just the smoke tests. So those pipelines now have new scenarios.

webUITrashbinDelete/trashbinDelete.feature:29 is failing in that environment (smaller screen). It might be a real problem with the web app on a small screen, or it might be a problem with the test code not managing to scroll things into view correctly...

I raised issue #5372 and added the scenario to the relevant expected-failures files.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16858/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/16858/38/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:353

@phil-davis phil-davis merged commit 274ea6b into master Jun 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the choose-tests-for-ocisSmokeTest branch June 25, 2021 11:54
@dpakach dpakach mentioned this pull request Jul 1, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScharfViktor @CLAassistant @ownclouders @phil-davis