Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send cookie on manifest.json #5553

Merged
merged 2 commits into from
Jul 21, 2021
Merged

send cookie on manifest.json #5553

merged 2 commits into from
Jul 21, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jul 21, 2021 •
edited
Loading

Description

Requests to manifest.json are performed without any authorization / cookies.

Related Issue

Motivation and Context

For the ownCloud 10 to oCIS migration strategy we want to utilize cookies, to decide where to route requests. Therefore every request needs to send the cookie, also manifest.json.

How Has This Been Tested?

  • test environment: dev setup (add a cookie and see if it was added to the manifest.json request)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek changed the title [CI skip] send cookie on manifest.json send cookie on manifest.json Jul 21, 2021
@wkloucek wkloucek force-pushed the send_cookie_on_manifest branch from 5bfeb8a to 2434a58 Compare July 21, 2021 11:10
@wkloucek wkloucek mentioned this pull request Jul 21, 2021
Merged
9 tasks
@wkloucek wkloucek marked this pull request as ready for review July 21, 2021 11:12
@wkloucek wkloucek requested a review from LukasHirt July 21, 2021 11:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pascalwengerter
pascalwengerter approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍪

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/17560/39/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

kulmann
kulmann approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit f188e9b into master Jul 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the send_cookie_on_manifest branch July 21, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wkloucek @ownclouders @kulmann @pascalwengerter @LukasHirt