Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] feat: redesign recipient roles select #5632

Merged
merged 12 commits into from
Sep 7, 2021
Merged

[full-ci] feat: redesign recipient roles select #5632

merged 12 commits into from
Sep 7, 2021

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Aug 5, 2021 •
edited
Loading

Screenshots

image

image

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Aug 5, 2021
@LukasHirt LukasHirt self-assigned this Aug 5, 2021
@update-docs

This comment has been minimized.

Sign in to view
@LukasHirt LukasHirt changed the title feat: redesign recipient roles select [full-ci] feat: redesign recipient roles select Aug 5, 2021
@ownclouders

This comment has been minimized.

Sign in to view
@ownclouders

This comment has been minimized.

Sign in to view
@ownclouders

This comment has been minimized.

Sign in to view
@ownclouders

This comment has been minimized.

Sign in to view
@LukasHirt LukasHirt force-pushed the feat/redesign-role-dropdown branch from 732d2e3 to aefb690 Compare August 5, 2021 10:38
@ownclouders

This comment has been minimized.

Sign in to view
@ownclouders

This comment has been minimized.

Sign in to view
@ownclouders

This comment has been minimized.

Sign in to view
@ownclouders

This comment has been minimized.

Sign in to view
@LukasHirt LukasHirt mentioned this pull request Aug 8, 2021
Merged
3 tasks
@LukasHirt LukasHirt force-pushed the feat/redesign-role-dropdown branch from 5900f3e to 9563cf9 Compare August 13, 2021 13:23
@LukasHirt LukasHirt marked this pull request as ready for review August 13, 2021 13:24
kulmann
kulmann suggested changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dropdown is not keyboard navigatable. Will take care of this next week. Otherwise in a good state 👍

@ownclouders

This comment has been minimized.

Sign in to view
@LukasHirt
Copy link
Collaborator Author

LukasHirt commented Aug 30, 2021 •
edited
Loading

The dropdown is not keyboard navigatable. Will take care of this next week. Otherwise in a good state +1

@kulmann That's taken care of by @fschade in #5647 should I cherry-pick it also here?

@LukasHirt LukasHirt force-pushed the feat/redesign-role-dropdown branch from 5e038f7 to b2a29cc Compare August 30, 2021 09:26
@ownclouders

This comment has been minimized.

Sign in to view
@ownclouders

This comment has been minimized.

Sign in to view
@LukasHirt LukasHirt requested a review from kulmann September 1, 2021 08:56
@LukasHirt
Copy link
Collaborator Author

@kulmann ready for re-review

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18787/34/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/publicLinkIndicator.feature:27

kulmann
kulmann suggested changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2021-09-02 at 16 13 58

my hover and focus state has a white background 👀

@LukasHirt
Copy link
Collaborator Author

LukasHirt commented Sep 2, 2021 •
edited
Loading

my hover and focus state has a white background eyes

@kulmann that's strange. Could you pls check what css var is assigned there? I am seeing it just fine 🤷 --oc-color-swatch-primary-default should be the one used there

@ownclouders
Copy link
Contributor

Results for oC10CreateDelete https://drone.owncloud.com/owncloud/web/18804/9/1
The following scenarios passed on retry:

  • webUICreateFilesFolders/createFolderEdgeCases.feature:43

@pascalwengerter
Copy link
Contributor

my hover and focus state has a white background eyes

@kulmann that's strange. Could you pls check what css var is assigned there? I am seeing it just fine shrug --oc-color-swatch-primary-default should be the one used there

Can't reproduce either

pascalwengerter
pascalwengerter reviewed Sep 7, 2021
View reviewed changes
packages/web-app-files/src/components/SideBar/Shares/Collaborators/CollaboratorsEditOptions.vue
<template #special>
<oc-list class="files-recipient-role-drop-list" :aria-label="rolesListAriaLabel">
<li v-for="role in roles" :key="role.name">
<oc-button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how accessible this solution is as of now 🤔 let's talk about this in the web call today

@pascalwengerter
Copy link
Contributor

CI failed with the odd npm-install hangup in one pipeline btw

kulmann
kulmann approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO good to merge now. Regarding accessibility, might be needed to cycle through the list with up/down arrows AND with tab. What do you think? 🤔

@kulmann
Copy link
Contributor

kulmann commented Sep 7, 2021

my hover and focus state has a white background eyes

@kulmann that's strange. Could you pls check what css var is assigned there? I am seeing it just fine shrug --oc-color-swatch-primary-default should be the one used there

Can't reproduce either

Yeah, me neither anymore... weird. Sorry for the noise.

@LukasHirt LukasHirt force-pushed the feat/redesign-role-dropdown branch from 1af4d78 to 681ea84 Compare September 7, 2021 10:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders

This comment has been minimized.

Sign in to view
@LukasHirt LukasHirt requested a review from lookacat September 7, 2021 11:18
@pascalwengerter
Copy link
Contributor

IMO good to merge now. Regarding accessibility, might be needed to cycle through the list with up/down arrows AND with tab. What do you think? thinking

Yeah I expected it to work with tab navigation (same as the OcDrops in the app-switcher-menu and user-profile-menu, basically) but it directly opened the Datepicker, at least in OC10. Happy to merge this now and open another ticket to investigate, though

lookacat
lookacat approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LukasHirt LukasHirt merged commit 52c0181 into master Sep 7, 2021
@LukasHirt LukasHirt deleted the feat/redesign-role-dropdown branch September 7, 2021 11:46
@LukasHirt LukasHirt linked an issue Sep 7, 2021 that may be closed by this pull request
Add role & exp. date to oc-invite formfield #5764
Closed
@micbar micbar mentioned this pull request Sep 15, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@kulmann kulmann kulmann approved these changes

@lookacat lookacat lookacat approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@LukasHirt LukasHirt

Labels
Category:Enhancement Add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add role & exp. date to oc-invite formfield
5 participants
@LukasHirt @ownclouders @pascalwengerter @kulmann @lookacat