-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] feat: fetch file info in the sidebar #5665
Conversation
This comment has been minimized.
This comment has been minimized.
720f144
to
19dbef9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
11db051
to
8230081
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
91093c0
to
3be03cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previews in the right sidebar are broken
packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
Outdated
Show resolved
Hide resolved
60a679f
to
9e92f8a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | ||
|
||
highlightedFileThumbnail() { | ||
return this.highlightedFile.thumbnail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a thumbnail
(small resolution) and preview
(bigger resolution) for files. The thumbnails are shown in the files list. The previews are shown in the right sidebar. So this should be about previews, not thumbnails, since you're targeting the right sidebar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview is being loaded in the FileDetails component. In there, it first checks if the file has the thumbnail so that it knows if it should try to load the bigger one or not. I got a bit confused here as well but didn't want to bloat the size of this PR even more with refactoring this so I've just made sure the current behaviour is still working.
v-if="highlightedFile.thumbnail" |
preview: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh. We have an option for disabling thumbnails entirely. If that's the case we apparently kill the preview in the sidebar, just because thumbnails in the list are off.
Understandable though that fixing that is out of scope for this PR. 😞
I cannot reproduce this anymore. Switching selected files/folders like crazy, trying multiple selection, no selection... and no error 🤷 |
93577e0
to
15285ff
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤩
Please don't merge until #5770 is merged 😬 |
d21f689
to
ff11bb1
Compare
Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18997/28/1
|
Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18997/34/1
|
Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18997/40/1
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Kudos, SonarCloud Quality Gate passed! |
Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/19004/28/1
|
If a single item is selected, fetch a fileInfo. This gives us information about the item even in shared lists.