Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] feat: fetch file info in the sidebar #5665

Merged
merged 17 commits into from
Sep 9, 2021

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Aug 12, 2021

If a single item is selected, fetch a fileInfo. This gives us information about the item even in shared lists.

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Aug 12, 2021
@LukasHirt LukasHirt self-assigned this Aug 12, 2021
@update-docs

This comment has been minimized.

@LukasHirt LukasHirt force-pushed the feat/shared-list-private-link branch from 720f144 to 19dbef9 Compare August 13, 2021 09:51
@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@LukasHirt LukasHirt force-pushed the feat/shared-list-private-link branch from 11db051 to 8230081 Compare September 1, 2021 10:46
@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@LukasHirt LukasHirt linked an issue Sep 1, 2021 that may be closed by this pull request
@LukasHirt LukasHirt marked this pull request as ready for review September 1, 2021 14:01
@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@LukasHirt LukasHirt force-pushed the feat/shared-list-private-link branch from 91093c0 to 3be03cc Compare September 2, 2021 13:21
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previews in the right sidebar are broken

@LukasHirt LukasHirt force-pushed the feat/shared-list-private-link branch from 60a679f to 9e92f8a Compare September 6, 2021 07:53
@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting quite some errors in the js console, see screenshot. 👀

Screenshot 2021-09-07 at 09 57 06

},

highlightedFileThumbnail() {
return this.highlightedFile.thumbnail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a thumbnail (small resolution) and preview (bigger resolution) for files. The thumbnails are shown in the files list. The previews are shown in the right sidebar. So this should be about previews, not thumbnails, since you're targeting the right sidebar.

Copy link
Collaborator Author

@LukasHirt LukasHirt Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview is being loaded in the FileDetails component. In there, it first checks if the file has the thumbnail so that it knows if it should try to load the bigger one or not. I got a bit confused here as well but didn't want to bloat the size of this PR even more with refactoring this so I've just made sure the current behaviour is still working.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh. We have an option for disabling thumbnails entirely. If that's the case we apparently kill the preview in the sidebar, just because thumbnails in the list are off.
Understandable though that fixing that is out of scope for this PR. 😞

@kulmann
Copy link
Contributor

kulmann commented Sep 7, 2021

Getting quite some errors in the js console, see screenshot. 👀

Screenshot 2021-09-07 at 09 57 06

I still get these errors when having the right sidebar open and navigating through folders (up/down the tree).

@LukasHirt
Copy link
Collaborator Author

I still get these errors when having the right sidebar open and navigating through folders (up/down the tree).

I cannot reproduce this anymore. Switching selected files/folders like crazy, trying multiple selection, no selection... and no error 🤷

@LukasHirt LukasHirt force-pushed the feat/shared-list-private-link branch from 93577e0 to 15285ff Compare September 8, 2021 12:24
@ownclouders

This comment has been minimized.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤩

@pascalwengerter
Copy link
Contributor

Please don't merge until #5770 is merged 😬

@kulmann kulmann force-pushed the feat/shared-list-private-link branch from d21f689 to ff11bb1 Compare September 9, 2021 15:25
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18997/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18997/34/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/publicLinkIndicator.feature:27

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18997/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:111

@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

61.6% 61.6% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/19004/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@kulmann kulmann merged commit d1bd129 into master Sep 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/shared-list-private-link branch September 9, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No private link in right sidebar of Shared with me page
5 participants