Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patch vue-router): url / to %2F encoding #5715

Merged
merged 10 commits into from
Sep 6, 2021
Merged

fix(patch vue-router): url / to %2F encoding #5715

merged 10 commits into from
Sep 6, 2021

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Aug 21, 2021 •
edited
Loading

vue router v3* encodes slashes, pr fixes this temporary till we bump the router.

fixes: #5714

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18507/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/18507/65/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

kulmann
kulmann suggested changes Aug 21, 2021
View reviewed changes
packages/web-app-files/src/index.js Outdated Show resolved Hide resolved
packages/web-app-files/src/index.js Show resolved Hide resolved
packages/web-app-files/src/index.js Outdated Show resolved Hide resolved
@pascalwengerter
Copy link
Contributor

Linking #4595 here

kulmann
kulmann reviewed Aug 25, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.... could you also look into real blanks in URLs instead of %20? So that New Folder will be New Folder instead of New%20Folder in the URL? 🤔

@fschade fschade force-pushed the patch-vue-router-decoding branch from 70c656d to 8267ca8 Compare September 2, 2021 14:55
@fschade
Copy link
Contributor Author

fschade commented Sep 2, 2021

wait for owncloud/owncloud-design-system#1626

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Sep 2, 2021 •
edited
Loading

@fschade I changed the merge target branch, please rebase on #5770 (motivation for this is outlined there). You can then use the ODS 10.0.0 including the updated pagination

Also, please squash on merge 😉

@pascalwengerter pascalwengerter changed the base branch from master to 02092021_bump-ods-10.0.0 September 2, 2021 19:20
pascalwengerter
pascalwengerter reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an integration test for the pagination as well and I'm wondering why you didn't have to touch that...could you take a look?

changelog/unreleased/bugfix-url-encoding Outdated
@@ -0,0 +1,7 @@
Bugfix: url encoding / decoding

Fixes Vue router (prior to version 4) encoding from `files/all/folder` to `files%2Fall%2Ffolder`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you fix it the other way around? 🤔

@pascalwengerter
Copy link
Contributor

Also, is this a bugfix or a breaking change for users (since, e.g., bookmarks don't work anymore as they should)?

@pascalwengerter pascalwengerter force-pushed the 02092021_bump-ods-10.0.0 branch from bc62c4f to e90131c Compare September 3, 2021 10:24
@lookacat lookacat force-pushed the 02092021_bump-ods-10.0.0 branch from e90131c to 144706c Compare September 6, 2021 07:38
pascalwengerter and others added 7 commits September 6, 2021 09:18
@pascalwengerter
Merge branch '02092021_bump-ods-10.0.0' of github.com:owncloud/web in…
67997e5 
…to 02092021_bump-ods-10.0.0
@fschade @pascalwengerter
fix(patch vue-router): url / to %2F decoding
42acc7d 
vue router v3* encodes slashes, this fixes this as temporary till we
bump the router
@fschade @pascalwengerter
change changelog type
ff7d0d3
@fschade @pascalwengerter
feat(files): refactor pagination
1da4ab7 
refactor pagination from files to dedicated store module and use query
parameter instead of param
@fschade @pascalwengerter
fix(files): fix new errors from rebase
389164d
@fschade @pascalwengerter
fix pagination to work in integration tests
9e3e97c 
also add real pathes to files-personal files-public-list files-location-picker
fix location picker root copy url
@pascalwengerter
Add changelog for copy/move fixes whilst patching Vue router
1dd3cd4
@pascalwengerter pascalwengerter force-pushed the patch-vue-router-decoding branch from 3b4dbc4 to 1dd3cd4 Compare September 6, 2021 08:33
@ownclouders
Copy link
Contributor

Results for oCISSharingInternalUsers2 https://drone.owncloud.com/owncloud/web/18860/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

41.2% 41.2% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingInternalUsers2 https://drone.owncloud.com/owncloud/web/18879/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

kulmann
kulmann approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💪

@kulmann kulmann merged commit 5077440 into 02092021_bump-ods-10.0.0 Sep 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the patch-vue-router-decoding branch September 6, 2021 15:28
@pascalwengerter pascalwengerter mentioned this pull request Sep 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

research: find temporary workaround of how to get path variable with infinite segments without vue3
4 participants
@fschade @ownclouders @pascalwengerter @kulmann