Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robots.txt file #5762

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Add robots.txt file #5762

merged 3 commits into from
Sep 1, 2021

Conversation

jvillafanez
Copy link
Member

Description

Add the robots.txt file

Related Issue

owncloud/ocis#1314

Motivation and Context

How Has This Been Tested?

Checked with ocis-web without pulling fresh assets. After generating the embed files and building ocis, the "/robots.txt" is accessible with the contents.
It's expected that a new web release will put everything into the right place.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Sep 1, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2021

CLA assistant check
All committers have signed the CLA.

@kulmann
Copy link
Contributor

kulmann commented Sep 1, 2021

What about an integration into oc10 with the web app? Does the robots.txt of oc10 itself apply then or do we need to serve this robots.txt there as well? robots.txt would need to be added to the array in

$permittedPaths = ["css", "img", "js", "themes", "index.html", "manifest.json", "oidc-callback.html", "oidc-silent-redirect.html"];
then.

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18756/46/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:14

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18756/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@fschade
Copy link
Contributor

fschade commented Sep 1, 2021

Thanks, I think It misses a copy step here

targets: [

@jvillafanez
Copy link
Member Author

I don't think it's needed for the OC10 integration. OC10 already has its own robots.txt file so it's ownCloud the one that should serve the file.
In addition, the robots.txt should be placed in the root of the of the server, so it should be placed in https://my.server/robots.txt, and that URL is controlled by OC10, so the web app shouldn't need to bother

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18761/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@pascalwengerter pascalwengerter merged commit 8d06bae into master Sep 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the add_robots_file branch September 1, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants