create files for available mimetypes #5890

elizavetaRa · 2021-10-08T08:44:37Z

Description

Allow creation of files for mimetypes with set flag "allow_creation"

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

fix scroll to the created file

update-docs · 2021-10-08T08:44:40Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

packages/web-app-files/src/components/AppBar/AppBar.vue

diocas · 2021-11-29T13:51:24Z

@kulmann @pascalwengerter I've rebased with the latest master. I've also added some fixes @elizavetaRa had to do last week. (I couldn't mark things as resolved, as I'm not the creator of this PR).
Let us know if there's anything else missing or if we can merge this. Thanks

kulmann

Tried this locally with the ocis wopi deployment example, only got http 500: error creating resource errors when trying to create a file. 🤔 Do you have a special environment for being able to create files or is this unrelated to wopi? Opening documents works fine in the same instance... any idea?

kulmann · 2021-11-29T17:29:54Z

packages/web-app-files/src/components/AppBar/AppBar.vue

+          resource = await this.$client.publicFiles.getFileInfo(
+            path,
+            this.publicLinkPassword,
+            DavProperties.Default


Suggested change

DavProperties.Default

DavProperties.PublicLink

kulmann · 2021-11-29T17:31:28Z

packages/web-app-files/src/components/AppBar/AppBar.vue

+      } catch (error) {
+        this.showMessage({
+          title: this.$gettext('Creating file failed…'),
+          desc: error,


I'd prefer to leave out the error, only use the title. Make sure that it gets printed to the console. Presenting http error codes to users is not good UX. 😁

I removed it from the message here but the same error message is used in upstream addNewFiles()

The one for addNewFiles is not good either 😁 Feel free to adapt in this PR as well, but also fine to do it in a separate one. Thanks for changing it!

packages/web-app-files/src/components/AppBar/AppBar.vue

elizavetaRa · 2021-11-30T09:27:34Z

Tried this locally with the ocis wopi deployment example, only got http 500: error creating resource errors when trying to create a file. thinking Do you have a special environment for being able to create files or is this unrelated to wopi? Opening documents works fine in the same instance... any idea?

@ishank011 do you know anything about it?

Also @kulmann it would be nice to have the request implementation for /app/new?filename= in sdk

ishank011 · 2021-11-30T09:36:41Z

Tried this locally with the ocis wopi deployment example, only got http 500: error creating resource errors when trying to create a file. thinking Do you have a special environment for being able to create files or is this unrelated to wopi? Opening documents works fine in the same instance... any idea?

@kulmann can you share the reva logs?

ownclouders · 2021-11-30T09:51:48Z

Results for oCISFavorites https://drone.owncloud.com/owncloud/web/20542/55/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

diocas · 2021-12-17T16:18:03Z

I've rebased. Please do not merge as the last commit is not final, I still need a reply from @wkloucek to understand how I should auth in public links.
(maybe @elizavetaRa can put this as WIP?)

wkloucek · 2021-12-17T16:35:39Z

I've rebased. Please do not merge as the last commit is not final, I still need a reply from @wkloucek to understand how I should auth in public links. (maybe @elizavetaRa can put this as WIP?)

Is currently not implemented in REVA, cs3org/reva#2385 will add it.

ownclouders · 2021-12-17T16:54:50Z

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21164/15/1
The following scenarios passed on retry:

webUISharingAcceptSharesToRoot/acceptShares.feature:108

diocas · 2021-12-20T14:49:18Z

@wkloucek let me know when this PR is available in OCIS so that I can do a final test (I've asked Hugo to merge this morning, so the REVA side is done). And should I send the token as a header or query param?

wkloucek · 2021-12-21T09:09:17Z

@wkloucek let me know when this PR is available in OCIS so that I can do a final test (I've asked Hugo to merge this morning, so the REVA side is done). And should I send the token as a header or query param?

REVA was updated in oCIS and a new docker image will be available within the next hour.
In that case I would go with the public-token header.
@kulmann / @pascalwengerter Can you please confirm this?

diocas · 2021-12-21T10:31:33Z

PR updated. Checked and it was working in public links (although, new_url was coming back empty, had to manually change it, so please have a look there).
Doesn't work in password protected pl's (don't see the extensions in the menu), but I suppose is related to #5863

ownclouders · 2021-12-21T11:02:28Z

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/21251/41/1
The following scenarios passed on retry:

webUISharingExternalToRoot/federationSharing.feature:378

diocas · 2022-01-10T15:41:13Z

PR updated with latest. @kulmann @pascalwengerter let us know if we need to change anything.

sonarqubecloud · 2022-01-10T15:47:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
No Duplication information

ownclouders · 2022-01-10T16:06:56Z

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/21715/38/1
The following scenarios passed on retry:

webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:33

ownclouders · 2022-01-10T16:07:16Z

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/21715/68/1
The following scenarios passed on retry:

webUIPrivateLinks/accessingPrivateLinks.feature:17

kulmann · 2022-01-25T14:43:49Z

Continued in #6312 but still not working for me. I get an http 500 on every POST to the app provider for creating files.

diocas · 2022-01-25T15:47:39Z

@kulmann for any app or a particular one? Latest OCIS?

kulmann · 2022-01-25T15:49:06Z

@kulmann for any app or a particular one? Latest OCIS?

ocis_wopi deployment example, all container images up to date, happening for all apps in the create menu.

diocas · 2022-01-25T22:11:35Z

I confirm now I see the error as well (before it was not happening). Someone from the backend needs to check.
Just guessing: I see some error messages like "user.ocis.quota: no data available" and the creation error returned is "error calling InitiateFileUpload" so it might be related to this?
Btw, I guess we can close this PR since it was superseded (and maybe merge the other if the backend fix takes time - this is super urgent to us)

kulmann · 2022-01-25T22:29:19Z

I confirm now I see the error as well (before it was not happening). Someone from the backend needs to check.
Just guessing: I see some error messages like "user.ocis.quota: no data available" and the creation error returned is "error calling InitiateFileUpload" so it might be related to this?
Btw, I guess we can close this PR since it was superseded (and maybe merge the other if the backend fix takes time - this is super urgent to us)

Ok, thanks for confirming. Can you open a ticket for the backend?
I'll close here, as you also suggested. Superseded by #6312
CI is green on #6312 - since the code is not mine I'll force-merge it without additional review.

elizavetaRa requested review from fschade, kulmann and pascalwengerter as code owners October 8, 2021 08:44

elizavetaRa added the Early-Adopter:CERN label Oct 8, 2021

elizavetaRa force-pushed the create_files branch from 57fa6b4 to 21282dd Compare October 8, 2021 09:16

kulmann suggested changes Oct 13, 2021

View reviewed changes

This was referenced Nov 4, 2021

state of oCIS office integration owncloud/ocis#2721

Closed

fix app provider new file action and improve app provider error codes cs3org/reva#2210

Merged

elizavetaRa force-pushed the create_files branch from 21282dd to c46208b Compare November 8, 2021 11:47

kulmann reviewed Nov 8, 2021

View reviewed changes

packages/web-app-files/src/components/AppBar/AppBar.vue Outdated Show resolved Hide resolved

elizavetaRa force-pushed the create_files branch 4 times, most recently from 12f31cf to 27b33e2 Compare November 9, 2021 16:35

pascalwengerter reviewed Nov 10, 2021

View reviewed changes

packages/web-app-files/src/components/AppBar/AppBar.vue Outdated Show resolved Hide resolved

diocas pushed a commit to cernbox/web that referenced this pull request Nov 16, 2021

create files for available mimetypes owncloud#5890

8aa796e

diocas pushed a commit to cernbox/web that referenced this pull request Nov 16, 2021

create files for available mimetypes owncloud#5890

1e2e593

diocas pushed a commit to cernbox/web that referenced this pull request Nov 16, 2021

create files for available mimetypes owncloud#5890

f107776

diocas added a commit to cernbox/web that referenced this pull request Nov 16, 2021

create files for available mimetypes owncloud#5890

84a122e

diocas added a commit to cernbox/web that referenced this pull request Nov 17, 2021

create files for available mimetypes owncloud#5890

3b8e9d7

diocas added a commit to cernbox/web that referenced this pull request Nov 23, 2021

create files for available mimetypes owncloud#5890

bbc0b15

diocas force-pushed the create_files branch from bae2bd6 to 339cae0 Compare November 29, 2021 13:47

kulmann suggested changes Nov 29, 2021

View reviewed changes

kulmann reviewed Nov 30, 2021

View reviewed changes

packages/web-app-files/src/components/AppBar/AppBar.vue Outdated Show resolved Hide resolved

diocas force-pushed the create_files branch from 47c3f17 to 5f43e0b Compare November 30, 2021 15:23

diocas force-pushed the create_files branch from 9c2c435 to 86b16e8 Compare December 17, 2021 16:16

wkloucek mentioned this pull request Dec 20, 2021

[full-ci] update reva owncloud/ocis#2902

Merged

diocas force-pushed the create_files branch 2 times, most recently from 40ebb0d to 681e0fc Compare December 21, 2021 10:30

wkloucek mentioned this pull request Dec 21, 2021

fix app provider "new url" capability owncloud/ocis#2908

Merged

Create files for available mimetypes in app provider

d77bc05

diocas force-pushed the create_files branch from 681e0fc to d77bc05 Compare January 10, 2022 15:36

Adapt to latest changes

c5d5602

kulmann mentioned this pull request Jan 25, 2022

App provider create files #6312

Merged

9 tasks

kulmann closed this Jan 25, 2022

diocas deleted the create_files branch January 25, 2022 22:37

diocas mentioned this pull request Jan 25, 2022

Create app provider new file fails owncloud/ocis#3034

Closed

micbar mentioned this pull request Feb 16, 2022

Release 1.17.0 Tech Preview owncloud/ocis#2998

Closed

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create files for available mimetypes #5890

create files for available mimetypes #5890

elizavetaRa commented Oct 8, 2021

update-docs bot commented Oct 8, 2021

diocas commented Nov 29, 2021

kulmann left a comment

kulmann Nov 29, 2021

kulmann Nov 29, 2021

elizavetaRa Nov 30, 2021

kulmann Dec 3, 2021

elizavetaRa commented Nov 30, 2021

ishank011 commented Nov 30, 2021

ownclouders commented Nov 30, 2021

diocas commented Dec 17, 2021

wkloucek commented Dec 17, 2021

ownclouders commented Dec 17, 2021

diocas commented Dec 20, 2021

wkloucek commented Dec 21, 2021

diocas commented Dec 21, 2021

ownclouders commented Dec 21, 2021

diocas commented Jan 10, 2022

sonarqubecloud bot commented Jan 10, 2022

ownclouders commented Jan 10, 2022

ownclouders commented Jan 10, 2022

kulmann commented Jan 25, 2022

diocas commented Jan 25, 2022

kulmann commented Jan 25, 2022

diocas commented Jan 25, 2022

kulmann commented Jan 25, 2022

create files for available mimetypes #5890

create files for available mimetypes #5890

Conversation

elizavetaRa commented Oct 8, 2021

Description

Types of changes

Checklist:

Open tasks:

update-docs bot commented Oct 8, 2021

diocas commented Nov 29, 2021

kulmann left a comment

Choose a reason for hiding this comment

kulmann Nov 29, 2021

Choose a reason for hiding this comment

kulmann Nov 29, 2021

Choose a reason for hiding this comment

elizavetaRa Nov 30, 2021

Choose a reason for hiding this comment

kulmann Dec 3, 2021

Choose a reason for hiding this comment

elizavetaRa commented Nov 30, 2021

ishank011 commented Nov 30, 2021

ownclouders commented Nov 30, 2021

diocas commented Dec 17, 2021

wkloucek commented Dec 17, 2021

ownclouders commented Dec 17, 2021

diocas commented Dec 20, 2021

wkloucek commented Dec 21, 2021

diocas commented Dec 21, 2021

ownclouders commented Dec 21, 2021

diocas commented Jan 10, 2022

sonarqubecloud bot commented Jan 10, 2022

ownclouders commented Jan 10, 2022

ownclouders commented Jan 10, 2022

kulmann commented Jan 25, 2022

diocas commented Jan 25, 2022

kulmann commented Jan 25, 2022

diocas commented Jan 25, 2022

kulmann commented Jan 25, 2022