External apps errorhandling #6145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
force-pushed
the
external-apps-errorhandling
branch
from
af43f6d to
5bf9eb1
Compare
pascalwengerter
force-pushed
the
external-apps-errorhandling
branch
from
5bf9eb1 to
8634b48
Compare
|
@diocas updated the tests for the external app in this PR, feel free to take a look. Was mostly about mocking an error response and making sure the components behave how we expect them to behave after your changes 😉 |
|
Can also be force-merged after manual testing from my perspective. Neither smoke nor acceptance tests do anything with the app provider things. Also sorry for the |
pascalwengerter
force-pushed
the
external-apps-errorhandling
branch
from
8634b48 to
b56d957
Compare
|
Rebased on current master with less flaky smoke tests, CI should become green now |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finalizes #6003, should take care of fixing the external app (snapshot) tests
Related Issue