Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate public route for external apps #6151

Closed
wants to merge 2 commits into from

Conversation

diocas
Copy link
Contributor

@diocas diocas commented Dec 14, 2021

Quick fix to ensure that we redirect users to the idp when trying to open files with external apps that are not from public links.

Fixes #6069
Potentially fixes #6045

@update-docs
Copy link

update-docs bot commented Dec 14, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ishank011
Copy link

@diocas we also need to pass the public-token header for public links, right?

@ishank011
Copy link

@diocas we also need to pass the public-token header for public links, right?

This is already there, looks good

@pascalwengerter
Copy link
Contributor

@diocas this one needs a rebase since we merged a big PR changing routes yesterday:)

@diocas
Copy link
Contributor Author

diocas commented Jan 10, 2022

@pascalwengerter @fschade PR updated

@diocas
Copy link
Contributor Author

diocas commented Jan 26, 2022

Superseded by #6314

@diocas diocas closed this Jan 26, 2022
@diocas diocas deleted the up_app_p_in_pl branch January 26, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New requests to external apps are unauthenticated Open a document in a external app via bookmark fails
3 participants