Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve people sharing sidebar #6176

Merged
merged 2 commits into from
Dec 21, 2021
Merged

improve people sharing sidebar #6176

merged 2 commits into from
Dec 21, 2021

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Dec 20, 2021

Description

  • support enforced and max expiration date in the people/group sharing sidebar panel
  • update test-ids to differentiate between people and group list entries

Related Issue

Motivation and Context

support enforced-/max dates in sharing dialogue

How Has This Been Tested?

  • unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • e2e tests updated

@fschade fschade added the Status:Needs-Review Needs review from a maintainer label Dec 20, 2021
@fschade fschade requested a review from kulmann as a code owner December 20, 2021 19:42
@fschade fschade self-assigned this Dec 20, 2021
@update-docs
Copy link

update-docs bot commented Dec 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

kulmann
kulmann suggested changes Dec 20, 2021
View reviewed changes
changelog/4.7.0_2021-12-16/enhancement-respect-share-expiration-date Outdated Show resolved Hide resolved
changelog/4.7.0_2021-12-16/enhancement-respect-share-expiration-date Outdated Show resolved Hide resolved
...ages/web-app-files/src/components/SideBar/Shares/InviteCollaborator/ExpirationDatepicker.vue Outdated Show resolved Hide resolved
...ages/web-app-files/src/components/SideBar/Shares/InviteCollaborator/ExpirationDatepicker.vue Outdated Show resolved Hide resolved
...ages/web-app-files/src/components/SideBar/Shares/InviteCollaborator/ExpirationDatepicker.vue Outdated Show resolved Hide resolved
...ages/web-app-files/src/components/SideBar/Shares/InviteCollaborator/ExpirationDatepicker.vue Outdated Show resolved Hide resolved
...ages/web-app-files/src/components/SideBar/Shares/InviteCollaborator/ExpirationDatepicker.vue Outdated Show resolved Hide resolved
...ages/web-app-files/src/components/SideBar/Shares/InviteCollaborator/ExpirationDatepicker.vue Outdated Show resolved Hide resolved
...ages/web-app-files/src/components/SideBar/Shares/InviteCollaborator/ExpirationDatepicker.vue Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

Results for oC10SharingIntGroupsToRoot https://drone.owncloud.com/owncloud/web/21222/29/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

pascalwengerter
pascalwengerter reviewed Dec 20, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check again with a fresh eye tomorrow, but looks pretty awesome already. Thanks for taking care!

packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue Show resolved Hide resolved
packages/web-runtime/package.json Show resolved Hide resolved
@pascalwengerter pascalwengerter mentioned this pull request Dec 21, 2021
Closed
22 tasks
@fschade fschade force-pushed the reactive-share-expiration-date branch from ce3b4cc to c094e4e Compare December 21, 2021 15:47
@fschade
differentiate collaborator test-id for user and group
926bc0b 
support enforced and max expiration share dates
@fschade fschade force-pushed the reactive-share-expiration-date branch from c094e4e to bf66f38 Compare December 21, 2021 20:50
kulmann
kulmann approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the adjustments, looks more than just good to me! ❤️

@fschade
set default translation language to en for files-app
e1da726 
fix bug on initial event emit for expirationDatepicker after adding group or user
@fschade fschade force-pushed the reactive-share-expiration-date branch from 9936dc1 to e1da726 Compare December 21, 2021 21:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

95.3% 95.3% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 230ca5b into master Dec 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the reactive-share-expiration-date branch December 21, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@kulmann kulmann kulmann approved these changes

Assignees

@fschade fschade

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fschade @ownclouders @kulmann @pascalwengerter