Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] enable capability loading for password protected public links #6471

Merged
merged 2 commits into from
Mar 3, 2022
Merged

[full-ci] enable capability loading for password protected public links #6471

merged 2 commits into from
Mar 3, 2022

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Feb 23, 2022 •
edited
Loading

Description

as title says, enable capability loading for password protected public links.

Related Issue

Motivation and Context

#5863

How Has This Been Tested?

  • unit & integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Code changes

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/23008/55/1
The following scenarios passed on retry:

  • webUIMarkdownEditor/markdownFile.feature:50

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23008/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@fschade fschade changed the title enable capability loading for password protected public links [full-ci] enable capability loading for password protected public links Feb 23, 2022
@fschade fschade mentioned this pull request Feb 23, 2022
Merged
1 task
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23018/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@fschade
Copy link
Contributor Author

fschade commented Feb 23, 2022 •
edited
Loading

@diocas can you please test the pr if it fit your needs? To test it please use this ocis branch owncloud/ocis#3229

the failing ci is expected till the ocis pr is merged

@kulmann
Copy link
Contributor

kulmann commented Mar 2, 2022

@fschade PR in ocis has been merged, what needs to be done here to get it out of draft state?

@fschade
Copy link
Contributor Author

fschade commented Mar 2, 2022

@kulmann i need to (re)-test it with current ocis master, ill do that today after having bumped the web-rc.1 in ocis.

@fschade fschade force-pushed the public-link-password-capabilities branch from 9eb55da to 667c151 Compare March 3, 2022 10:56
@fschade fschade marked this pull request as ready for review March 3, 2022 10:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😍

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23222/68/1
The following scenarios passed on retry:

  • webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:169

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23222/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:105

@kulmann kulmann merged commit f0450c1 into master Mar 3, 2022
@kulmann kulmann mentioned this pull request Mar 3, 2022
Closed
31 tasks
@micbar micbar mentioned this pull request Mar 3, 2022
Closed
26 tasks
@pascalwengerter pascalwengerter deleted the public-link-password-capabilities branch April 1, 2022 12:25
@tbsbdr tbsbdr mentioned this pull request Jul 10, 2023
Closed
37 tasks
@tbsbdr tbsbdr added this to the CERN Web Merge milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
Early-Adopter:CERN Platform:Web
Projects
None yet
Milestone
CERN Web Merge
Development

Successfully merging this pull request may close these issues.

No capabilities in public context with password
4 participants
@fschade @ownclouders @kulmann @tbsbdr