refactor: replace deprecated String.prototype.substr() #6718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
|
@CommanderRoot thanks for the effort, could you rebase and squash your commits so we can merge? :) |
.substr() is deprecated so we replace it with functions which work similarily but aren't deprecated Signed-off-by: Tobias Speicher <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Apr 12, 2022
| @@ -170,7 +170,8 @@ export default { | |||
| isSameResource(this.resourcesToDelete[0], this.currentFolder) | |||
| ) { | |||
| const resourcePath = this.resourcesToDelete[0].path | |||
| parentFolderPath = resourcePath.substr(0, resourcePath.lastIndexOf('/')) | |||
| const lastSlash = resourcePath.lastIndexOf('/') | |||
| parentFolderPath = resourcePath.slice(0, lastSlash !== -1 ? lastSlash : 0) | |||
There was a problem hiding this comment.
I think I would've handled the lastSlash being -1 outside of slice, but it works as expected, so I'm fine with it. 😉
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.
Related Issue
Motivation and Context
String.prototype.substr() is deprecated .
How Has This Been Tested?
I tested the return of each statement to make sure it's still the same as before
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: