Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markdown-editor to simple-editor alias for config compatibility #6754

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Add markdown-editor to simple-editor alias for config compatibility #6754

merged 1 commit into from
Apr 7, 2022

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Apr 7, 2022

Description

The markdown-editor has recently been renamed to simple-editor. In order to not break old configs this PR adds an alias for the app bootstraping (i.e. when markdown-editor gets found in a config.json it gets replaced with simple-editor during runtime, before the apps are being loaded).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition towards the release!

@pascalwengerter pascalwengerter merged commit 552993f into master Apr 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the markdown-editor-alias branch April 7, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @pascalwengerter