Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Apply selection range without extension to new file dialog #6760

Closed
wants to merge 1 commit into from

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Apr 7, 2022

Description

Input field selection range was only applied to rename modal (select name without extension for file names). With this PR it's also applied to the create file modal.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann force-pushed the new-file-selection-without-extension branch 2 times, most recently from a8e826a to 2ac0620 Compare April 8, 2022 11:05
@ownclouders
Copy link
Contributor

ownclouders commented Apr 8, 2022

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/24681/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@kulmann kulmann force-pushed the new-file-selection-without-extension branch 2 times, most recently from b189dd0 to 036fc2e Compare April 11, 2022 13:44
@kulmann
Copy link
Contributor Author

kulmann commented Apr 11, 2022

rebased with current master again, to get unit tests passing

@kulmann kulmann force-pushed the new-file-selection-without-extension branch from 036fc2e to dad34dd Compare April 12, 2022 07:57
@kulmann kulmann changed the title Apply selection range without extension to new file dialog [full-ci] Apply selection range without extension to new file dialog Apr 12, 2022
@kulmann kulmann force-pushed the new-file-selection-without-extension branch from dad34dd to f891405 Compare April 12, 2022 07:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 3 Code Smells

43.8% 43.8% Coverage
0.0% 0.0% Duplication

@kulmann
Copy link
Contributor Author

kulmann commented Apr 22, 2022

Superseded by #6803

@kulmann kulmann closed this Apr 22, 2022
@kulmann kulmann deleted the new-file-selection-without-extension branch June 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text selection range not applied for new files
3 participants