-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search to usersManagement #6779
Conversation
add filter logic implementation inside usersManagement users list component
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
packages/web-app-user-management/src/components/Users/UsersList.vue
Outdated
Show resolved
Hide resolved
dddab81
to
15cf9e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one weird effect: mark.js highlights all occurrences of the search term, while the filtering doesn't work that way. This leads to filtering by admin
, not seeing all users that have the admin role (only those who have admin in their username, name or email) but still getting the role Admin
highlighted. Another indicator that we should refactor the role into the user, but of course for a separate PR and not something that blocks this PR. Could you open a bug ticket please?
Filtering and highlighting works really well.
I see a contrast issue though: in dark mode the text is barely readable. Please open a bug ticket for that as well.
Changelog item is missing (for that I have to request changes
😅 will approve once you added it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Kudos, SonarCloud Quality Gate passed! |
handover @janackermann
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: