Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search to usersManagement #6779

Merged
merged 7 commits into from
Apr 13, 2022
Merged

Add search to usersManagement #6779

merged 7 commits into from
Apr 13, 2022

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Apr 12, 2022

handover @janackermann

Description

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

add filter logic implementation inside usersManagement users list component
@update-docs
Copy link

update-docs bot commented Apr 12, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title [WIP] Prepare search for usersManagement Add search to usersManagement Apr 12, 2022
@AlexAndBear AlexAndBear marked this pull request as ready for review April 12, 2022 13:51
@AlexAndBear AlexAndBear requested a review from kulmann April 12, 2022 13:51
@AlexAndBear AlexAndBear requested a review from kulmann April 13, 2022 07:15
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one weird effect: mark.js highlights all occurrences of the search term, while the filtering doesn't work that way. This leads to filtering by admin, not seeing all users that have the admin role (only those who have admin in their username, name or email) but still getting the role Admin highlighted. Another indicator that we should refactor the role into the user, but of course for a separate PR and not something that blocks this PR. Could you open a bug ticket please?

Filtering and highlighting works really well.

I see a contrast issue though: in dark mode the text is barely readable. Please open a bug ticket for that as well.

Changelog item is missing (for that I have to request changes 😅 will approve once you added it)

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

47.7% 47.7% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit fb6ca30 into master Apr 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the accounts-filter branch April 13, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering and sorting of users list
3 participants