[full-ci] Tags #7385
Merged
[full-ci] Tags #7385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/27539/57/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFilesActionMenu-fileFolderActionMenu_feature-L14.pngwebUIFilesActionMenu-fileFolderActionMenu_feature-L37.png |
fschade
force-pushed
the
tags-experimental
branch
from
416e779 to
875e6df
Compare
add keys tags key to filter search bump sdk to experimental version open details sidebar instead of tags sidebar panel when navigation through files table more tags link update search input value when search query changes add list all tags endpoint and use it when entering a tag phrase
fschade
force-pushed
the
tags-experimental
branch
from
875e6df to
e26bc50
Compare
fschade
approved these changes
Aug 15, 2022
| } | ||
| }, | ||
| mounted() { | ||
| this.editAssignedTags = [...this.resource.tags] |
There was a problem hiding this comment.
why unspreading? the contained objects are still references.
There was a problem hiding this comment.
happens multiple times in the component.
There was a problem hiding this comment.
Containing objects are just strings, and they won't be edited...
We need to make sure, that the revert action still works -> which it does ;)
|
SonarCloud Quality Gate failed. |
fschade
added a commit
that referenced
this pull request
Aug 16, 2022
* change ocis to experimental change sdk to experimental * bump ocis commit id * Add tags to ResourceTable (#7388) * Add tags to resourcetable * Use file tags instead of tags * Add changelog, remove border for + item * Replace OcFileTag * Dump ODS * [full-ci] Tags (#7385) Tags init * Truncate tags (#7442) Truncate tags Co-authored-by: Paul Neubauer <[email protected]> Co-authored-by: Jan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EXPERIMENTAL!
Managing files via tags is now possible in web, the feature is experimental and will be only available through a dedicated experimental web build.
Beside that the web version is experimental, it also needs a special experimental ocis version.
Creating Tags, tagging resources and search for tags now is possible and can be used as an alternative way of working and organizing resources.
Types of changes
Checklist:
Open tasks: