[full-ci] Load spaces in runtime #7425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
force-pushed
the
spaces-in-runtime
branch
from
60f56ff to
28a44c1
Compare
AlexAndBear
previously requested changes
Aug 9, 2022
There was a problem hiding this comment.
IHMO the UPDATE_SPACE_FIELD mutation should be moved to packages/web-runtime/src/store/spaces.ts
kulmann
suggested changes
Aug 9, 2022
packages/web-app-files/src/services/folder/loaderPublicFiles.ts
Outdated
Show resolved
Hide resolved
Merged
9 tasks
dschmidt
force-pushed
the
spaces-in-runtime
branch
2 times, most recently
from
da71b60 to
6634953
Compare
This converts a bunch of files to TypeScript and fixes one or two potential errors that became apparent after the conversion.
dschmidt
force-pushed
the
spaces-in-runtime
branch
from
6634953 to
6d8b1a7
Compare
dschmidt
force-pushed
the
spaces-in-runtime
branch
from
6d8b1a7 to
9d326c0
Compare
|
SonarCloud Quality Gate failed. |
kulmann
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts a bunch of files to TypeScript and fixes one or two potential errors that became apparent after the conversion.
I'm sorry this got so huge, but splitting it into separate commits would have been a big effort and we would have merged it to master anyway, so I didn't want to invest that much time...
Description
This moves the spaces loading into web-runtime (from web-app-files) in order to prepare
driveAliashandling that we will need in files app and other file handling apps.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: