Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'Copy Quicklink'-translations #7731

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Fix 'Copy Quicklink'-translations #7731

merged 3 commits into from
Oct 4, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Oct 4, 2022 •
edited
Loading

Description

We've fixed a bug where the translation for the "Copy Quicklink"-notification was not working.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Oct 4, 2022
@owncloud owncloud deleted a comment from update-docs bot Oct 4, 2022
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/28824/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkCreate_feature-L165.png

webUISharingPublicBasic-publicLinkCreate_feature-L165.png

💥 The oCISSharingPublic1 tests pipeline failed. The build has been cancelled.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit c31f5d0 into master Oct 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-copy-quicklink-translations branch October 4, 2022 14:47
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@JammingBen @ownclouders @AlexAndBear