Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance email validation proccess #7894

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Enhance email validation proccess #7894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24e35c8
Enhance email validation proccess
Oct 31, 2022
cc1b164
Add changelog item
Oct 31, 2022
283b1b4
Update changelog item
Nov 2, 2022
02b17d6
Lint
Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-optimize-email-validation
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Optimize email validation in the user management app

We've optimized the email validation process while creating users in the user management app to provide
a better user experience.

https://github.com/owncloud/web/pull/7894
https://github.com/owncloud/web/issues/7806
9 changes: 9 additions & 0 deletions packages/web-app-user-management/src/components/Users/CreateUserModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
:error-message="formData.email.errorMessage"
type="email"
:fix-message-line="true"
@input="onInputEmail"
@change="validateEmail"
/>
<oc-text-input
Expand Down Expand Up @@ -100,6 +101,14 @@ export default {
}
},
methods: {
onInputEmail() {
if (!EmailValidator.validate(this.user.mail)) {
return
}

this.formData.email.errorMessage = ''
this.formData.email.valid = true
},
validateUserName() {
this.formData.userName.valid = false

Expand Down