Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default XHR timeout and make it configurable #7912

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Increase default XHR timeout and make it configurable #7912

merged 3 commits into from
Nov 3, 2022

Conversation

JammingBen
Copy link
Contributor

Description

The default timeout for XHR uploads has been increased from 30 to 60 seconds. Also, it can now be configured via the config.json file (in ms).

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen added the Category:Enhancement Add new functionality label Nov 3, 2022
@JammingBen JammingBen self-assigned this Nov 3, 2022
@JammingBen JammingBen mentioned this pull request Nov 3, 2022
Closed
kulmann
kulmann suggested changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short description of the new option to the getting started page in the docs folder (there is a section for options).

@JammingBen JammingBen requested a review from kulmann November 3, 2022 11:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@JammingBen JammingBen merged commit a2f6296 into master Nov 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the xhr-timeout branch November 3, 2022 11:42
ownclouders pushed a commit that referenced this pull request Nov 3, 2022
@JammingBen
commit a2f6296
575c177 
Merge: fb41f4c 0df3aba
Author: Jannik Stehle <[email protected]>
Date:   Thu Nov 3 12:42:20 2022 +0100

    Merge pull request #7912 from owncloud/xhr-timeout

    Increase default XHR timeout and make it configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@JammingBen JammingBen

Labels
Category:Enhancement Add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload of big files is failing in CERNBox: Uppy error "Upload stalled for 30 seconds, aborting."
2 participants
@JammingBen @kulmann