Include spaces in the list info #7926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
suggested changes
Nov 14, 2022
kulmann
suggested changes
Nov 15, 2022
| @@ -37,7 +48,8 @@ export default { | |||
| }, | |||
| computed: { | |||
| items() { | |||
| return this.files + this.folders | |||
| const filesAndFolderCount = this.files + this.folders | |||
| return this.showSpaces ? filesAndFolderCount + this.spaces : filesAndFolderCount | |||
There was a problem hiding this comment.
Why not single line as follows?
return this.files + this.folders + (this.showSpaces ? this.spaces : 0)There was a problem hiding this comment.
And more radical: isn't this.spaces always 0 if this.showSpaces evaluates to false? In that case you could just do
return this.files + this.folders + this.spacesThere was a problem hiding this comment.
isn't this.spaces always 0 if this.showSpaces evaluates to false?
Technically, this.spaces could be >0 while showSpaces is still false. I don't like those 2 props to be "linked" together like this... The first suggestion is nice though.
JammingBen
force-pushed
the
list-info-spaces-count
branch
from
b600815 to
071e81b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Nov 15, 2022
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spaces have been included in the list info below file lists that support displaying spaces.
Related Issue
Screenshot:
Types of changes