Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit panel for users who never logged in #8326

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Jan 26, 2023

Description

Made edit panel more resilient. As of today, the backend sends an empty drive object for users who never logged in.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Jan 26, 2023
@AlexAndBear
Copy link
Contributor

Well this was my fault.
I never noticed that error.

Nvm: thx!

@kulmann
Copy link
Contributor Author

kulmann commented Jan 26, 2023

Well this was my fault. I never noticed that error.

Nvm: thx!

huh? backend change was introduced today. it behaved perfectly before.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jan 26, 2023

I made some changes in the frontend as well, which might have cause a problem.

Edit: combination of fronted and backend changes, thx for fix 😇

@kulmann
Copy link
Contributor Author

kulmann commented Jan 26, 2023

I made some changes in the frontend as well, which might have cause a problem.

nope, those were unrelated

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 30df9eb into master Jan 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-user-edit-empty-drive branch January 27, 2023 07:41
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants