Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init admin settings general #8360

Merged
merged 9 commits into from
Feb 3, 2023
Merged

Init admin settings general #8360

merged 9 commits into from
Feb 3, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 3, 2023 •
edited by kulmann
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Feb 3, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear
Copy link
Contributor Author

stalled, waiting for backend changes

@kulmann
Copy link
Contributor

kulmann commented Feb 3, 2023

stalled, waiting for backend changes

Not stalled :-) There is the requirement to build an Info section in the General view. The appearance section can happen later in another PR.

@AlexAndBear AlexAndBear marked this pull request as ready for review February 3, 2023 11:53
@AlexAndBear AlexAndBear requested a review from kulmann February 3, 2023 11:53
JammingBen
JammingBen reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nit picks. Also, unit tests would be nice 🙂

packages/web-app-admin-settings/src/components/General/Info.vue Outdated Show resolved Hide resolved
packages/web-app-admin-settings/src/index.ts Show resolved Hide resolved
packages/web-app-admin-settings/src/components/General/AppearanceSettings.vue Outdated Show resolved Hide resolved
kulmann
kulmann approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

36.1% 36.1% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 1092cac into master Feb 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the admin-settings-general branch February 3, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Add "General" View
3 participants
@AlexAndBear @kulmann @JammingBen