Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension-sdk: Add a shared vite config for extensions #8407

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Feb 9, 2023

Description

Add a shared vite config file that can be used to develop external extensions.

Related Issue

Motivation and Context

How Has This Been Tested?

We ported

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Feb 9, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dschmidt dschmidt marked this pull request as ready for review February 9, 2023 16:48
@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32686/75/1
💥 The oC10IntegrationApp2 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32686/73/1
💥 The oC10IntegrationNotifications tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32686/74/1
💥 The oC10IntegrationApp1 tests pipeline failed. The build has been cancelled.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@diocas
Copy link
Contributor

diocas commented Feb 13, 2023

Hi @dschmidt @kulmann , just a "small favour". I know this is not a very important PR, but it's also not that big nor changes the web code in a meaningful way..
So, do you think you could merge it today? This way I would avoid a fork to build our extensions.

@kulmann
Copy link
Contributor

kulmann commented Feb 13, 2023

@dschmidt do you still want to add anything to this PR or can it be merged?

@dschmidt
Copy link
Member Author

Ok to merge I guess

@kulmann kulmann merged commit ffbf327 into master Feb 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the extension-sdk branch February 13, 2023 21:48
@diocas
Copy link
Contributor

diocas commented Feb 14, 2023

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants