Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only] fix removing user from group test #8633

Merged
merged 1 commit into from
Mar 16, 2023
Merged

[test-only] fix removing user from group test #8633

merged 1 commit into from
Mar 16, 2023

Conversation

ScharfViktor
Copy link
Contributor

fix origin fixFlakyRemovingUsersFromGroup

@update-docs
Copy link

update-docs bot commented Mar 16, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor requested a review from butonic March 16, 2023 11:32
butonic
butonic approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@ScharfViktor ScharfViktor mentioned this pull request Mar 16, 2023
Merged
@JammingBen
Copy link
Contributor

JammingBen commented Mar 16, 2023 •
edited
Loading

@ScharfViktor Should we do similar when adding users to groups? 🤔

@ScharfViktor
Copy link
Contributor Author

@ScharfViktor Should we do similar when adding users to groups? 🤔

Yes, to make more confidence. thank you)

@ScharfViktor ScharfViktor requested a review from JammingBen March 16, 2023 12:20
@ScharfViktor ScharfViktor force-pushed the fixFlakyRemovingUsersFromGroup branch from b6e5cf4 to a0e87f3 Compare March 16, 2023 12:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit 1cf0e65 into master Mar 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the fixFlakyRemovingUsersFromGroup branch March 16, 2023 12:51
@butonic butonic mentioned this pull request Mar 16, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScharfViktor @JammingBen @butonic