Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set max length of a breadcrumb item #8769

Closed
wants to merge 3 commits into from

Conversation

elizavetaRa
Copy link
Member

Description

Adds config option breadcrumbItemMaxLength for max length of a breadcrumb item (desktop version)

  • With the option set to > 0 the item text gets cut to max length + "..."
  • Shorten items get a tooltip with the full item text

Related Issue

#6731

Motivation and Context

UI improvement

Screenshots (if appropriate):

Long items without pr
before

Long items with pr
after

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Should the last item always be fully visible?
  • Should max length be also used for mobile version (drop)? But it doesn't have the same problem as a multiline list
  • Now added only to breadcrumb in AppBar.vue . Where else it makes sense to add?

@update-docs
Copy link

update-docs bot commented Apr 3, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@elizavetaRa
Copy link
Member Author

@tbsbdr Could you give your opinion on the following:

  • Should the last item always be fully visible? Currently, it can also be shorten with this option.
  • Should max length also be used for mobile version (drop)? But it doesn't have the same problem as a multiline list, so, currently, not.
  • Now added only to the web-app-files breadcrumb in AppBar.vue. Where else it makes sense to add?

@tbsbdr
Copy link

tbsbdr commented Apr 4, 2023

  • Should the last item always be fully visible? Currently, it can also be shorten with this option.

I'd say: last item is always not truncated (but tbh I have no super strong opinion about it)

  • Should max length also be used for mobile version (drop)? But it doesn't have the same problem as a multiline list, so, currently, not.

jep👍 I think the same

  • Now added only to the web-app-files breadcrumb in AppBar.vue. Where else it makes sense to add?

Administration Settings: I think its not necessary to truncate all breadcrumbs in Administration settings, having the truncation in the files app is only is perfectly sufficient

@kulmann
Copy link
Contributor

kulmann commented May 24, 2023

Superseded by #8984

@kulmann kulmann closed this May 24, 2023
@diocas diocas deleted the breadcrumb-2 branch July 24, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants