Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: select-all checkbox checks items in other list #9131

Merged
merged 3 commits into from
May 30, 2023
Merged

Bugfix: select-all checkbox checks items in other list #9131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c04f17
Add a check to the computed prop if selectedResources are even in the…
lookacat May 30, 2023
a9d02b5
Add changelog
lookacat May 30, 2023
e470d2b
Simplify code
lookacat May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-select-all-checkbox
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Select all checkbox

We've fixed a bug in the shared-with-me page which caused unrelated checkboxes to be checked.

https://github.com/owncloud/web/pull/9131
https://github.com/owncloud/web/issues/9122
2 changes: 1 addition & 1 deletion packages/web-app-files/src/components/FilesList/ResourceTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ export default defineComponent({
return this.configuration?.options?.displayResourcesLazy
},
areAllResourcesSelected() {
return this.selectedIds.length === this.resources.length
return this.selectedResources.length === this.resources.length
},
selectedResources() {
return this.resources.filter((resource) => this.selectedIds.includes(resource.id))
Expand Down