Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] fix: initial space preloading performance #9153

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Jun 5, 2023

Description

This PR reduces the initial space preloading to only loading personal and project spaces. The virtual/shares space (share jail) is never needed and hence never loaded. The mountpoint spaces will be loaded on demand for now. This has some drawbacks (see comment in the code) but is necessary for performance tuning at the moment. Initially preloading the mountpoints might come back at a later point. Preloading the share jail makes no sense, as web doesn't use it, and will not be reintroduced.

Motivation and Context

Tuning performance and backend load, especially when a lot of users sign in at the same time.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Jun 5, 2023
@kulmann kulmann changed the title [full-ci] fix: initial space preloading [full-ci] fix: initial space preloading performance Jun 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

4.3% 4.3% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 0444703 into stable-7.0 Jun 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the reduce-initial-drives-listing branch June 6, 2023 07:41
ownclouders pushed a commit that referenced this pull request Jun 6, 2023
[full-ci] fix: initial space preloading performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants