Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Refactored steps order #9154

Merged
merged 1 commit into from
Jun 7, 2023
Merged

[full-ci] [tests-only] Refactored steps order #9154

merged 1 commit into from
Jun 7, 2023

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Jun 6, 2023 •
edited
Loading

Description

This PR refactors the order of steps,

Before::

And "Alice" logs in
And "Admin" assigns following roles to the users using API
      | id    | role        |
      | Alice | Space Admin |

Now::

And "Admin" assigns following roles to the users using API
      | id    | role        |
      | Alice | Space Admin |
And "Alice" logs in

Build:: https://drone.owncloud.com/owncloud/web/36331/10/12

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@grgprarup grgprarup force-pushed the debug-flaky-test branch 3 times, most recently from 2068b3e to fbab32f Compare June 6, 2023 11:45
@grgprarup grgprarup changed the title [Debug] [Do-Not-Merge][full-ci] [tests-only] Debug intermittent failure [full-ci] [tests-only] Debug intermittent failure Jun 7, 2023
@grgprarup grgprarup self-assigned this Jun 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the correct step flow. Please do port to stable7.0

tests/e2e/cucumber/features/smoke/spaces/project.ocis.feature Show resolved Hide resolved
@grgprarup grgprarup changed the title [full-ci] [tests-only] Debug intermittent failure [full-ci] [tests-only] Refactored steps order Jun 7, 2023
@grgprarup grgprarup mentioned this pull request Jun 7, 2023
Closed
@grgprarup grgprarup merged commit 1246fcd into master Jun 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the debug-flaky-test branch June 7, 2023 10:24
@grgprarup grgprarup mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent E2E tests failure on CI
2 participants
@grgprarup @saw-jan