prune shares while removing files #9697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
suggested changes
Sep 18, 2023
There was a problem hiding this comment.
The issue has not been fixed for me. removeFilesFromTrashbin seems like the wrong place since the trash bin is not involved here. Could you try again via the reproduction steps provided in #9538?
This reverts commit 3c30e78.
Sorry sorry, that was last minute mass up while cleaning up test code. It's supposed to be part of |
|
Kudos, SonarCloud Quality Gate passed! |
JammingBen
approved these changes
Sep 18, 2023
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* prune shares while removing files * Revert "prune shares while removing files" This reverts commit 3c30e78. * prune shares while removing files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Committing mutation PRUNE_SHARES while removing files, will reset links and prevents displaying previously added links to files or directories under same name
Related Issue
Types of changes
Checklist: