Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce extension disabling via config #9800

Merged
merged 1 commit into from
Oct 13, 2023
Merged

feat: introduce extension disabling via config #9800

merged 1 commit into from
Oct 13, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Oct 13, 2023 •
edited
Loading

Description

Adds a config option disabledExtensions which enables disabling specific extensions via their id.

oCIS part for the config: owncloud/ocis#7486

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Oct 13, 2023
@JammingBen JammingBen force-pushed the disabling-extensions branch from f00abdb to beccf2c Compare October 13, 2023 07:12
@JammingBen
feat: introduce extension disabling via config
34576d9 
Adds a config option `disabledExtensions` which enables disabling specific extensions via their id.
@JammingBen JammingBen force-pushed the disabling-extensions branch from beccf2c to 34576d9 Compare October 13, 2023 10:50
@JammingBen JammingBen marked this pull request as ready for review October 13, 2023 10:52
@JammingBen JammingBen mentioned this pull request Oct 13, 2023
Merged
5 tasks
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.0% 20.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

AlexAndBear
AlexAndBear approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dschmidt
dschmidt approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love how easy this was!

@JammingBen JammingBen merged commit 367ea10 into master Oct 13, 2023
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the disabling-extensions branch October 13, 2023 11:38
ownclouders pushed a commit that referenced this pull request Oct 13, 2023
@JammingBen
Merge pull request #9800 from owncloud/disabling-extensions
c4e638e 
feat: introduce extension disabling via config
@JammingBen JammingBen mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@dschmidt dschmidt dschmidt approved these changes

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make used search provider's configurable
3 participants
@JammingBen @dschmidt @AlexAndBear