-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: search query term linking #9854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookacat
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼 Nice change
fschade
added
Category:Enhancement
Add new functionality
Status:Needs-Review
Needs review from a maintainer
Estimation:S(2)
feature:files
Category:Change
Change existing functionality
labels
Oct 24, 2023
fschade
force-pushed
the
search-term-linking
branch
from
October 25, 2023 10:56
d11dab7
to
4bc897d
Compare
AlexAndBear
suggested changes
Oct 25, 2023
SonarCloud Quality Gate failed. 1 Bug 78.6% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
AlexAndBear
approved these changes
Oct 27, 2023
12 tasks
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* enhancement: search query term linking * enhancement: refactor filter update and make it reusable * fix: search list unit test * style: rename variables for better understanding --------- Co-authored-by: Jannik Stehle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category:Change
Change existing functionality
Category:Enhancement
Add new functionality
Estimation:S(2)
feature:files
Status:Needs-Review
Needs review from a maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this its possible to search for multiple terms with the same type,
at the moment only the tag search benefits from it.
This makes it possible to search for multiple resources with different tags in one query.
The UI now empowers the user to perform advanced searches like:
tag1
ORtag2
tag1
ORtag2
AND containing textcontent
as a rule of thumb, if a property appears multiple times (like
tag1
ORtag2
)the search combines the query with an
OR
and different keys are linked with anAND
.Related Issue
Motivation and Context
with the introduction of KQL in ocis the search syntax is defined by the MS spec, this brings web a step closer to it and empowers the user to submit even more complex queries.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
addedupdatedAcceptance tests addedDocumentation ticket raised:Open tasks: