Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: search query term linking #9854

Merged
merged 4 commits into from
Oct 29, 2023
Merged

enhancement: search query term linking #9854

merged 4 commits into from
Oct 29, 2023

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Oct 24, 2023

Description

With this its possible to search for multiple terms with the same type,
at the moment only the tag search benefits from it.

This makes it possible to search for multiple resources with different tags in one query.
The UI now empowers the user to perform advanced searches like:

  • all resources with the tags tag1 OR tag2
  • all resources with the tags tag1 OR tag2 AND containing text content

as a rule of thumb, if a property appears multiple times (like tag1 OR tag2)
the search combines the query with an OR and different keys are linked with an AND.

Related Issue

Motivation and Context

with the introduction of KQL in ocis the search syntax is defined by the MS spec, this brings web a step closer to it and empowers the user to submit even more complex queries.

How Has This Been Tested?

  • unit tests, (+ CI)

Screenshots (if appropriate):

276558127-538b6b67-02bf-427d-8797-da5f5f04856d

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added updated
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • wait for CI

@fschade fschade self-assigned this Oct 24, 2023
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Nice change

@fschade fschade added Category:Enhancement Add new functionality Status:Needs-Review Needs review from a maintainer Estimation:S(2) feature:files Category:Change Change existing functionality labels Oct 24, 2023
@fschade
Copy link
Contributor Author

fschade commented Oct 24, 2023

Please do not merge, I wanna have #9831 merged first, I’ll take care of testing and changes. Cc.: @grimmoc

back to draft for the moment

@fschade fschade marked this pull request as draft October 24, 2023 17:46
@fschade fschade force-pushed the search-term-linking branch from d11dab7 to 4bc897d Compare October 25, 2023 10:56
@fschade fschade marked this pull request as ready for review October 25, 2023 10:57
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

78.6% 78.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@fschade fschade merged commit 66acb8b into master Oct 29, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-term-linking branch October 29, 2023 07:20
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
* enhancement: search query term linking

* enhancement: refactor filter update and make it reusable

* fix: search list unit test

* style: rename variables for better understanding

---------

Co-authored-by: Jannik Stehle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Change Change existing functionality Category:Enhancement Add new functionality Estimation:S(2) feature:files Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: Refine Filter Logic
4 participants