Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parameter flip to the client endpoint #112

Merged
merged 1 commit into from
May 18, 2024

Conversation

zihaooo
Copy link
Contributor

@zihaooo zihaooo commented May 18, 2024

There are four orientations in total for the reMarkable 2 screen: two for portrait and two for landscape.
When the orientation of the reMarkable 2 screen changes, I also want goMarkableStream to rotate.
Since there is already an endpoint parameter portrait to control the portrait or landscape, I add another parameter flip to control if it needs to rotate 180 degrees at each case.

@owulveryck
Copy link
Owner

owulveryck commented May 18, 2024

Looks good to me and this fixes #105

Thank you very much for your contribution

@owulveryck owulveryck merged commit 087878d into owulveryck:main May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants