fix(linter): rule no-restricted-globals: do not check for globals…

… entries (#9139) Same as `no-console`. The rule does not really check for globals: https://eslint.org/docs/latest/rules/no-restricted-globals Updated the tests to include the globals / envs configuration: https://github.com/eslint/eslint/blob/main/tests/lib/rules/no-restricted-globals.js
oxc-project · Feb 15, 2025 · 29141d6 · 29141d6
1 parent 23d0d95
commit 29141d6
Showing 1 changed file with 64 additions and 28 deletions.
diff --git a/crates/oxc_linter/src/rules/eslint/no_restricted_globals.rs b/crates/oxc_linter/src/rules/eslint/no_restricted_globals.rs
@@ -86,7 +86,7 @@ impl Rule for NoRestrictedGlobals {
                 return;
             };
 
-            if ctx.is_reference_to_global_variable(ident) {
+            if ctx.scopes().root_unresolved_references().contains_key(ident.name.as_str()) {
                 ctx.diagnostic(no_restricted_globals(&ident.name, message, ident.span));
             }
         }
@@ -99,53 +99,89 @@ fn test() {
     const CUSTOM_MESSAGE: &str = "Use bar instead.";
 
     let pass = vec![
-        ("foo", None),
-        ("foo", Some(serde_json::json!(["bar"]))),
-        ("var foo = 1;", Some(serde_json::json!(["foo"]))),
-        ("event", Some(serde_json::json!(["bar"]))),
-        ("import foo from 'bar';", Some(serde_json::json!(["foo"]))),
-        ("function foo() {}", Some(serde_json::json!(["foo"]))),
-        ("function fn() { var foo; }", Some(serde_json::json!(["foo"]))),
-        ("foo.bar", Some(serde_json::json!(["bar"]))),
-        ("foo", Some(serde_json::json!([{ "name": "bar", "message": "Use baz instead." }]))),
+        ("foo", None, None),
+        ("foo", Some(serde_json::json!(["bar"])), None),
+        ("var foo = 1;", Some(serde_json::json!(["foo"])), None),
+        (
+            "event",
+            Some(serde_json::json!(["bar"])),
+            Some(serde_json::json!({ "env": { "browser": true }})),
+        ),
+        ("import foo from 'bar';", Some(serde_json::json!(["foo"])), None),
+        ("function foo() {}", Some(serde_json::json!(["foo"])), None),
+        ("function fn() { var foo; }", Some(serde_json::json!(["foo"])), None),
+        ("foo.bar", Some(serde_json::json!(["bar"])), None),
+        ("foo", Some(serde_json::json!([{ "name": "bar", "message": "Use baz instead." }])), None),
     ];
 
     let fail = vec![
-        ("foo", Some(serde_json::json!(["foo"]))),
-        ("function fn() { foo; }", Some(serde_json::json!(["foo"]))),
-        ("function fn() { foo; }", Some(serde_json::json!(["foo"]))),
-        ("event", Some(serde_json::json!(["foo", "event"]))),
-        ("foo", Some(serde_json::json!(["foo"]))),
-        ("foo()", Some(serde_json::json!(["foo"]))),
-        ("foo.bar()", Some(serde_json::json!(["foo"]))),
-        ("foo", Some(serde_json::json!([{ "name": "foo" }]))),
-        ("function fn() { foo; }", Some(serde_json::json!([{ "name": "foo" }]))),
-        ("function fn() { foo; }", Some(serde_json::json!([{ "name": "foo" }]))),
-        ("event", Some(serde_json::json!(["foo", { "name": "event" }]))),
-        ("foo", Some(serde_json::json!([{ "name": "foo" }]))),
-        ("foo()", Some(serde_json::json!([{ "name": "foo" }]))),
-        ("foo.bar()", Some(serde_json::json!([{ "name": "foo" }]))),
-        ("foo", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }]))),
+        ("foo", Some(serde_json::json!(["foo"])), None),
+        ("function fn() { foo; }", Some(serde_json::json!(["foo"])), None),
+        ("function fn() { foo; }", Some(serde_json::json!(["foo"])), None),
+        (
+            "event",
+            Some(serde_json::json!(["foo", "event"])),
+            Some(serde_json::json!({ "env": { "browser": true }})),
+        ),
+        (
+            "foo",
+            Some(serde_json::json!(["foo"])),
+            Some(serde_json::json!({ "globals": { "foo": false }})),
+        ),
+        ("foo()", Some(serde_json::json!(["foo"])), None),
+        ("foo.bar()", Some(serde_json::json!(["foo"])), None),
+        ("foo", Some(serde_json::json!([{ "name": "foo" }])), None),
+        ("function fn() { foo; }", Some(serde_json::json!([{ "name": "foo" }])), None),
+        (
+            "function fn() { foo; }",
+            Some(serde_json::json!([{ "name": "foo" }])),
+            Some(serde_json::json!({ "globals": { "foo": false }})),
+        ),
+        (
+            "event",
+            Some(serde_json::json!(["foo", { "name": "event" }])),
+            Some(serde_json::json!({ "env": { "browser": true }})),
+        ),
+        (
+            "foo",
+            Some(serde_json::json!([{ "name": "foo" }])),
+            Some(serde_json::json!({ "globals": { "foo": false }})),
+        ),
+        ("foo()", Some(serde_json::json!([{ "name": "foo" }])), None),
+        ("foo.bar()", Some(serde_json::json!([{ "name": "foo" }])), None),
+        ("foo", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])), None),
         (
             "function fn() { foo; }",
             Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])),
+            None,
         ),
         (
             "function fn() { foo; }",
             Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])),
+            Some(serde_json::json!({ "globals": { "foo": false }})),
         ),
         (
             "event",
             Some(
                 serde_json::json!(["foo", { "name": "event", "message": "Use local event parameter." }]),
             ),
+            Some(serde_json::json!({ "env": { "browser": true }})),
+        ),
+        (
+            "foo",
+            Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])),
+            Some(serde_json::json!({ "globals": { "foo": false }})),
+        ),
+        ("foo()", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])), None),
+        (
+            "foo.bar()",
+            Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])),
+            None,
         ),
-        ("foo", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }]))),
-        ("foo()", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }]))),
-        ("foo.bar()", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }]))),
         (
             "var foo = obj => hasOwnProperty(obj, 'name');",
             Some(serde_json::json!(["hasOwnProperty"])),
+            None,
         ),
     ];