refactor(linter): react/jsx_no_undef use loop instead of recursion (#…

…5347)
oxc-project · Aug 30, 2024 · afb038e · afb038e
1 parent be7b8c6
commit afb038e
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/crates/oxc_linter/src/rules/react/jsx_no_undef.rs b/crates/oxc_linter/src/rules/react/jsx_no_undef.rs
@@ -41,11 +41,15 @@ fn get_resolvable_ident<'a>(node: &'a JSXElementName<'a>) -> Option<&'a Identifi
     }
 }
 
-fn get_member_ident<'a>(expr: &'a JSXMemberExpression<'a>) -> Option<&'a IdentifierReference> {
-    match &expr.object {
-        JSXMemberExpressionObject::Identifier(_) => None,
-        JSXMemberExpressionObject::IdentifierReference(ident) => Some(ident),
-        JSXMemberExpressionObject::MemberExpression(next_expr) => get_member_ident(next_expr),
+fn get_member_ident<'a>(mut expr: &'a JSXMemberExpression<'a>) -> Option<&'a IdentifierReference> {
+    loop {
+        match &expr.object {
+            JSXMemberExpressionObject::Identifier(_) => return None,
+            JSXMemberExpressionObject::IdentifierReference(ident) => return Some(ident),
+            JSXMemberExpressionObject::MemberExpression(next_expr) => {
+                expr = next_expr;
+            }
+        }
     }
 }