fix(linter): rule unicorn/new-for-builtins do not look into `global…

…s` (#9146)
oxc-project · Feb 15, 2025 · b68e240 · b68e240
1 parent 490c77d
commit b68e240
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/crates/oxc_linter/src/rules/unicorn/new_for_builtins.rs b/crates/oxc_linter/src/rules/unicorn/new_for_builtins.rs
@@ -101,9 +101,16 @@ fn is_expr_global_builtin<'a, 'b>(
 ) -> Option<&'b str> {
     match expr {
         Expression::Identifier(ident) => {
-            if !ctx.is_reference_to_global_variable(ident) {
+            if !ctx.scopes().root_unresolved_references().contains_key(ident.name.as_str()) {
                 return None;
             }
+
+            if !ENFORCE_NEW_FOR_BUILTINS.contains(&ident.name)
+                && !DISALLOW_NEW_FOR_BUILTINS.contains(&ident.name)
+            {
+                return None;
+            }
+
             Some(ident.name.as_str())
         }
         match_member_expression!(Expression) => {