Skip to content

Commit

Permalink
feat(linter): add fixer for eslint/func_names (#4714)
Browse files Browse the repository at this point in the history
  • Loading branch information
DonIsaac committed Aug 7, 2024
1 parent 80557a9 commit eaddc8f
Show file tree
Hide file tree
Showing 5 changed files with 304 additions and 166 deletions.
8 changes: 4 additions & 4 deletions crates/oxc_ast/src/ast_impl/js.rs
Original file line number Diff line number Diff line change
Expand Up @@ -597,17 +597,17 @@ impl Argument<'_> {
}

impl<'a> AssignmentTarget<'a> {
pub fn get_identifier(&self) -> Option<&str> {
self.as_simple_assignment_target().and_then(|it| it.get_identifier())
pub fn get_identifier(&self) -> Option<&'a str> {
self.as_simple_assignment_target().and_then(SimpleAssignmentTarget::get_identifier)
}

pub fn get_expression(&self) -> Option<&Expression<'a>> {
self.as_simple_assignment_target().and_then(|it| it.get_expression())
self.as_simple_assignment_target().and_then(SimpleAssignmentTarget::get_expression)
}
}

impl<'a> SimpleAssignmentTarget<'a> {
pub fn get_identifier(&self) -> Option<&str> {
pub fn get_identifier(&self) -> Option<&'a str> {
match self {
Self::AssignmentTargetIdentifier(ident) => Some(ident.name.as_str()),
match_member_expression!(Self) => self.to_member_expression().static_property_name(),
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/fixer/fix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ bitflags! {
const None = 0;
const SafeFix = Self::Fix.bits();
const DangerousFix = Self::Dangerous.bits() | Self::Fix.bits();
/// Fixes and Suggestions that are safe or dangerous.
const All = Self::Dangerous.bits() | Self::Fix.bits() | Self::Suggestion.bits();
}
}

Expand Down
Loading

0 comments on commit eaddc8f

Please sign in to comment.