Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformer: differentiate import {} from "a"; and import from "a"; #3736

Closed
Boshen opened this issue Jun 18, 2024 · 3 comments · Fixed by #3866
Closed

transformer: differentiate import {} from "a"; and import from "a"; #3736

Boshen opened this issue Jun 18, 2024 · 3 comments · Fixed by #3866
Assignees
Labels
C-bug Category - Bug

Comments

@Boshen
Copy link
Member

Boshen commented Jun 18, 2024

Our AST differentiates import {} from "a"; and import from "a";

Failing babel test cases like imports/elide-no-import-specifiers/input.ts

Added failing test cases: https://github.com/oxc-project/oxc/pull/3735/files#diff-0a1b8e143f74590ed69ad0ad7abfcf2add6d7e6a9c3daff2bbb132b71e0f3f14

@Boshen Boshen added the C-bug Category - Bug label Jun 18, 2024
@Boshen
Copy link
Member Author

Boshen commented Jun 22, 2024

I tried this for 30 minutes but couldn't figure out 🙃

@overlookmotel
Copy link
Contributor

Do we want to distinguish them? Is there any semantic difference?

TypeScript seems to treat them differently: TS Playground

@Boshen
Copy link
Member Author

Boshen commented Jun 23, 2024

Do we want to distinguish them?

yes

Is there any semantic difference?

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants