Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON AST for changes to JSXElementName #5354

Closed
overlookmotel opened this issue Aug 30, 2024 · 0 comments · Fixed by #5882
Closed

Fix JSON AST for changes to JSXElementName #5354

overlookmotel opened this issue Aug 30, 2024 · 0 comments · Fixed by #5882
Assignees
@Boshen
Labels
A-ast Area - AST C-bug Category - Bug

Comments

@overlookmotel
Copy link
Contributor

#5223 altered JSXElementName and the JSON AST (via NAPI) will now be out of line with ESTree. Fix it.

Do this once we've finished all the changes - #5352, #5353.
@overlookmotel overlookmotel added C-bug Category - Bug A-ast Area - AST labels Aug 30, 2024
@overlookmotel overlookmotel mentioned this issue Aug 30, 2024
Closed
@Boshen Boshen self-assigned this Sep 7, 2024
Boshen added a commit that referenced this issue Sep 19, 2024
@Boshen
fix(ast): serialize JSXElementName to estree
6c7bf19 
closes #5354
@Boshen Boshen mentioned this issue Sep 19, 2024
Merged
Boshen added a commit that referenced this issue Sep 19, 2024
@Boshen
fix(ast): serialize JSXElementName to estree (#5882)
a822c9d 
closes #5354
@Boshen Boshen closed this as completed Sep 19, 2024
This was referenced Sep 19, 2024
Merged
Merged
Boshen pushed a commit that referenced this issue Sep 19, 2024
@overlookmotel
fix(ast): serialize JSXMemberExpressionObject to estree (#5883)
0d10521 
Follow-on after #5882, part of #5354.

Make JSON AST ESTree-compatible for:

* `<Foo.bar />`
* `<this.foo />`
Boshen pushed a commit that referenced this issue Sep 19, 2024
@overlookmotel
fix(ast): correct TS types for JSX (#5884)
66e919e 
Part of #5354. #5882 and #5883 corrected the JSON AST for JSX types to make it ESTree-compatible. Bring the TS types into line with those changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
A-ast Area - AST C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ast): serialize JSXElementName to estree oxc-project/oxc
2 participants
@overlookmotel @Boshen