Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): import/no-cycle should turn on ignore_types by default #6759

Closed
Boshen opened this issue Oct 22, 2024 Discussed in #6754 · 1 comment · Fixed by #6761
Closed

feat(linter): import/no-cycle should turn on ignore_types by default #6759

Boshen opened this issue Oct 22, 2024 Discussed in #6754 · 1 comment · Fixed by #6761
Assignees
@Boshen

Comments

@Boshen
Copy link
Member

Boshen commented Oct 22, 2024 •
edited
Loading

Discussed in #6754

Originally posted by JustFly1984 October 22, 2024
what is the benefit to fix circular imports for types? I get why it is bad between packages in workspaces, but why is it bad for the project files? @mattpococ Said that it has no pers issues, so why does oxlint complains on types?
@Boshen Boshen self-assigned this Oct 22, 2024
@Boshen
Copy link
Member Author

Boshen commented Oct 22, 2024

It has no benefit, ignore_types should be turned on by default.

Boshen added a commit that referenced this issue Oct 22, 2024
@Boshen
feat(linter): import/no-cycle should turn on ignore_types by default
ac755e2 
closes #6759
@Boshen Boshen mentioned this issue Oct 22, 2024
Merged
Boshen added a commit that referenced this issue Oct 22, 2024
@Boshen
feat(linter): import/no-cycle should turn on ignore_types by default (#…
dbe1972 
…6761)

closes #6759
@Boshen Boshen closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(linter): import/no-cycle should turn on ignore_types by default oxc-project/oxc
1 participant
@Boshen