-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remap eslint/prefer-spread
to unicorn/prefer-spread
#7948
Comments
imo, it would be easiest just to split the rules. |
Should we do the same for all remapped rules in https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/utils/mod.rs ? |
so my reasoning for spliting them is, iirc, Whereas the typescript ones as usually (i haven't checked this) the same as the eslint rule just with TS support Vitest is basically the same - its 99% the same code across jest/vitest for rules such as no identical title so no need to split I'm happy to be disagreed with though 🙂 |
This is my fault. You're correct that these are completely different rules. Let's revert that decision and separate these two rules. |
In this PR,
unicorn/prefer-spread
rule was migrated toeslint:prefer-spread
.So should we update status of
unicorn/prefer-spread
? (It seems to be not implemented status)Originally posted by @tbashiyy in #684 (comment)
Needs the same mapping like jest ot vitest
and then update the doc tasks too:
https://github.com/oxc-project/oxc/blob/main/tasks/lint_rules/src/oxlint-rules.cjs#L181-L198
The text was updated successfully, but these errors were encountered: