Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter) Fix false positives in prefer string start, ends with, port more test cases #1689

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 15, 2023

closes #1687 - uses intersection instead of ||:

  • this improves performance as it combines the flags into a single bitmask instead of doing two seperate checks

Adds missing test cases from eslint-plugin-unicorn

Copy link
Contributor Author

camc314 commented Dec 15, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the A-linter Area - Linter label Dec 15, 2023
@camc314 camc314 changed the title fix(linter) Fix false positives in prefer string start, ends with fix(linter) Fix false positives in prefer string start, ends with, port more test cases Dec 15, 2023
@camc314 camc314 marked this pull request as draft December 15, 2023 13:22
@camc314
Copy link
Contributor Author

camc314 commented Dec 15, 2023

Draft - waiting for #1688 to be merged first

@camc314 camc314 force-pushed the c/12-15-fix_linter_Fix_false_positives_in_prefer_string_start_ends_with branch from 62f6c46 to b91a9dd Compare December 15, 2023 17:02
@camc314 camc314 marked this pull request as ready for review December 15, 2023 17:02
@camc314 camc314 merged commit 6268f3f into main Dec 15, 2023
16 of 30 checks passed
@camc314 camc314 deleted the c/12-15-fix_linter_Fix_false_positives_in_prefer_string_start_ends_with branch December 15, 2023 17:08
Copy link
Contributor Author

camc314 commented Dec 15, 2023

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer-string-starts-ends-with ignores /i case insensitive modifier
1 participant