feat(linter): eslint-plugin-jsx-a11y role-support-aria-props #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camc314
reviewed
Jan 8, 2024
crates/oxc_linter/src/rules/jsx_a11y/role_support_aria_props.rs
Outdated
Show resolved
Hide resolved
camc314
reviewed
Jan 8, 2024
crates/oxc_linter/src/rules/jsx_a11y/role_support_aria_props.rs
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #1949 will improve performances by 7.48%Comparing Summary
Benchmarks breakdown
|
Boshen
added a commit
that referenced
this pull request
Jan 9, 2024
|
I reverted the change. I didn't notice there is a change to the test suite which breaks main 😅 |
|
Yes, sir. Sorry, I didn't mean to be so blunt! I didn't expect to destroy main’s test either. May I modify it and submit the PR again? |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…ject#1949) ## Summary partof: oxc-project#1141 I re-implemented role-support-aria-props rule for jsx_a11y. originals: - docs: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/role-supports-aria-props.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/role-supports-aria-props.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/role-supports-aria-props-test.js
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
partof: #1141
I re-implemented role-support-aria-props rule for jsx_a11y.
originals: