Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): only show the filename for max-lines #3966

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jun 29, 2024

closes #3961

Copy link

graphite-app bot commented Jun 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Jun 29, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2024
Copy link

graphite-app bot commented Jun 29, 2024

Merge activity

  • Jun 29, 4:38 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 29, 4:38 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 29, 4:44 AM EDT: Boshen merged this pull request with the Graphite merge queue.

Copy link

codspeed-hq bot commented Jun 29, 2024

CodSpeed Performance Report

Merging #3966 will not alter performance

Comparing max-lines (c26975a) with main (ba7dd02)

Summary

✅ 28 untouched benchmarks

@graphite-app graphite-app bot merged commit c26975a into main Jun 29, 2024
23 checks passed
@graphite-app graphite-app bot deleted the max-lines branch June 29, 2024 08:44
@github-actions github-actions bot mentioned this pull request Jun 29, 2024
Boshen added a commit that referenced this pull request Jun 29, 2024
## [0.5.1] - 2024-06-29

### Features

- f64ad4b semantic: Make jsdoc building optional (turned off by default)
(#3955) (Boshen)

### Bug Fixes

- c26975a linter: Only show the filename for max-lines (#3966) (Boshen)
- 94329e4 linter: Handle useful but empty constructors in
no-useless-constructor (#3951) (DonIsaac)
- 6498a08 linter: No-useless-spread fixer with multiple spread elements
(#3950) (DonIsaac)
- 750cb43 oxlint: Gate custom allocators by feature flag (#3945) (Luca
Bruno)

### Refactor

- 1cca2a8 eslint: Convert with_labels to with_label where applicable
(#3946) (Jelle van der Waa)
- 2705df9 linter: Improve diagnostic labeling (#3960) (DonIsaac)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: consider reducing the size of the diagnostic message for lint rule max-lines
1 participant