fix(linter): global variable check should always check builtin variables #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
Boshen
force-pushed
the
06-29-fix_linter_global_variable_check_should_always_check_builtin_variables
branch
from
f960ae1 to
dbbb6fc
Compare
graphite-app
bot
deleted the
06-29-fix_linter_global_variable_check_should_always_check_builtin_variables
branch
CodSpeed Performance ReportMerging #3973 will not alter performanceComparing Summary
|
This was referenced Jul 1, 2024
Closed
Merged
Boshen
added a commit
that referenced
this pull request
Jul 2, 2024
## [0.6.0] - 2024-07-02 - c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to `visit_arrow_function_expression`. (#3995) (rzvxa) ### Features - dc6d45e ast,codegen: Add `TSParenthesizedType` and print type parentheses correctly (#3979) (Boshen) - b257d53 linter: Support report `@typescript-eslint/consistent-type-imports` (#3895) (mysteryven) - 2114475 linter: Implement @typescript-eslint/no-dynamic-delete (#3971) (kaykdm) - 10a3c9a linter/eslint-plugin-react: Implement no-set-state (#3975) (Jelle van der Waa) ### Bug Fixes - 432d6d9 linter: Find disabled directives using the message's `Span`. (#4010) (rzvxa) - dbbb6fc linter: Global variable check should always check builtin variables (#3973) (Boshen) ### Performance - 1eac3d2 semantic: Use `Atom<'a>` for `Reference`s (#3972) (Don Isaac) ### Refactor Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3374