feat(linter): implement unicorn/no-negation-in-equality-check #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4034 will not alter performanceComparing Summary
|
mysteryven
reviewed
Jul 4, 2024
crates/oxc_linter/src/snapshots/no_negation_in_equality_check.snap
Outdated
Show resolved
Hide resolved
crates/oxc_linter/src/rules/unicorn/no_negation_in_equality_check.rs
Outdated
Show resolved
Hide resolved
|
Thank you! 😄 |
This was referenced Jul 7, 2024
Closed
Merged
Boshen
added a commit
that referenced
this pull request
Jul 7, 2024
## [0.5.3] - 2024-07-07 ### Features - 1681b11 linter: Eslint-plugin-jest/consistent-test-it (#4053) (cinchen) - 6876490 linter: Add rule no-undefined (#4041) (jordan boyer) - bf04dee linter: Implement unicorn/no-negation-in-equality-check (#4034) (Nissim Chekroun) - aa45604 linter/eslint: Implement no-multi-str (#4038) (Jelle van der Waa) ### Bug Fixes - 7b2dc3b linter: Fix panic in import/namespace (#4080) (Boshen) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3869
Hey there, thought I'd give this a try as it's tagged "good first issue" :) Let me know if there's anything that needs to change, I wasn't sure about the rule category so left as TODO.